google / samba-documents-provider

Access network file shares directly from the Android Downloads/Files app
GNU General Public License v3.0
650 stars 127 forks source link

Fix incorrect comparison with assignment #67

Open Rudd-O opened 4 years ago

Rudd-O commented 4 years ago

This should not set the address when comparing. Classic C error. Fixes #66.

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Rudd-O commented 4 years ago

I won't sign the CLA. Someone else needs to redo this PR.