google / sawbuck

Automatically exported from code.google.com/p/sawbuck
107 stars 40 forks source link

VS2010 - syzygy/pe/dos_stub.asm fails to parse, #51

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
1>------ Build started: Project: pe_lib, Configuration: Debug Win32 ------
1>Build started 2012-05-22 2:02:36 PM.
1>_Assemble:
1>  Assembling C:\src\syzygy\b\src\syzygy\pe\dos_stub.asm to 
C:\src\syzygy\b\src\syzygy\Debug\obj\pe_lib\dos_stub.obj.
1>  Microsoft (R) Macro Assembler Version 10.00.40219.01
1>  Copyright (C) Microsoft Corporation.  All rights reserved.
1>  
1>C:\src\syzygy\b\src\syzygy\pe\dos_stub.asm(16): error A2008: syntax error : .
1>C:\src\syzygy\b\src\syzygy\pe\pe_lib.targets(1,1589): error MSB3721: The 
command "ml "-safeseh" "-Zi" "-Fo" 
"C:\src\syzygy\b\src\syzygy\Debug\obj\pe_lib\dos_stub.obj" "-c" 
"C:\src\syzygy\b\src\syzygy\pe\dos_stub.asm"" exited with code 1.
1>
1>Project Performance Summary:
1>      535 ms  C:\src\syzygy\b\src\syzygy\pe\pe_lib.vcxproj   1 calls
1>                535 ms  _Assemble                                  1 calls
1>
1>Target Performance Summary:
1>        0 ms  ComputeAssembleOutput                      1 calls
1>        0 ms  PlatformPrepareForBuild                    1 calls
1>        0 ms  GetFrameworkPaths                          1 calls
1>        0 ms  GetReferenceAssemblyPaths                  1 calls
1>        0 ms  _SelectedFiles                             1 calls
1>        1 ms  PrepareForBuild                            1 calls
1>        3 ms  _CheckForInvalidConfigurationAndPlatform   1 calls
1>        3 ms  SetBuildDefaultEnvironmentVariables        1 calls
1>      528 ms  _Assemble                                  1 calls
1>
1>Task Performance Summary:
1>        0 ms  Message                                    3 calls
1>        1 ms  MakeDir                                    3 calls
1>        2 ms  WriteLinesToFile                           1 calls
1>        3 ms  SetEnv                                     4 calls
1>      193 ms  Assemble                                   1 calls
1>
1>Build FAILED.
1>
1>Time Elapsed 00:00:00.53
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

Original issue reported on code.google.com by rog...@chromium.org on 22 May 2012 at 6:03

GoogleCodeExporter commented 8 years ago
Support for the .286 directive was removed from the MASM that ships with VS2010.

Simply changing it to .386 and leaving the rest of the file compiles find and 
generates the expected output.

http://codereview.appspot.com/6223063/

Original comment by rog...@chromium.org on 25 May 2012 at 2:16