search

google / sawbuck

Automatically exported from code.google.com/p/sawbuck
107 stars 40 forks source link

run optimize.bat for chromium build, chrome.dll not optimized #80

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
hi,
   we use latest syzygy to optimize chromium 31 build. Copy the output files to "input-dir", then call "optimize.bat --verbose --input-dir=%s --output-dir=%s --iterations=10". We find the chrome_child.dll changed, bug chrome.dll not.
   After analyze the code, I think there is a problem in optimize.py. I list the pseudo-code following: 
def _OptimizeChrome
   _OptimizeChromeBinary("chrome.dll")   
   _OptimizeChromeBinary("chrome_child.dll")

def _OptimizeChromeBinary
   run reorder
   chrome_utils.CopyChromeFiles(chrome_dir, output_dir)
   run relinker

the problem is: after first call to _OptimizeChromeBinary, the chrome.dll in 
outpu_dir is optimized; but during second call to _OptimizeChromeBinary, the 
optimized chrome.dll is overwritten after call 
chrome_utils.CopyChromeFiles(chrome_dir, output_dir).
I think the solution could be: move the 
"chrome_utils.CopyChromeFiles(chrome_dir, output_dir)" to function 
_OptimizeChrome, just before the first _OptimizeChromeBinary.

Original issue reported on code.google.com by yaoming...@gmail.com on 6 Dec 2013 at 9:49