search

google / schema-dts

JSON-LD TypeScript types for Schema.org vocabulary
Apache License 2.0
860 stars 32 forks source link

Add an install option for pending #183

Closed thadguidry closed 1 year ago

thadguidry commented 2 years ago

Perhaps something like: npm install schema-dts-pending

This would add the Schema.org core vocabulary inclusive of the Pending Section

Eyas commented 2 years ago

Hmm. This looks like a regression from #8 , we're defaulting to https://schema.org/version/latest/schemaorg-current-https.jsonld instead of https://schema.org/version/latest/schemaorg-all-https.jsonld

thadguidry commented 1 year ago

@Eyas hmm, but I guess a workaround or straightforward way for me to add Pending would be to simply do:

npm install schema-dts-gen
npx schema-dts-gen --ontology=https://schema.org/version/latest/schemaorg-all-https.jsonld

as mentioned on https://github.com/google/schema-dts/blob/main/packages/schema-dts-gen/README.md ? (jsonld ending and not nt)

your README.md for schema-dts does NOT include pending (but pending is what I want to include and hence this issue):

schema-dts Pre-packaged TypeScript typings of latest Schema.org schema, without pending and other non-core layers.

So can I override the default easily through the command structure, or we need to add another arg option to --include: pending or some such?

Eyas commented 1 year ago

Fixed in v1.1.2