search

google / schemarama

Schemarama is a project exploring standards-based validation for structured data, especially Schema.org.
Apache License 2.0
124 stars 22 forks source link

SHACL busted in UI even if core tests pass #33

Closed danbri closed 1 year ago

danbri commented 2 years ago

I remember someone commenting on this when the original demos were still online. I can replicate it in OSX with current main branch and same behaviour with various packages updated. I suggest we bring the JS all up to date and investigate from there. @ericprud also has it somehow working again, if slowly. We think the issue is to do with the large set of 11000 or so triples from schema.org. I have also begun trying to reproduce the problem as a unit test for core/.

danbri commented 1 year ago

This is fixed in ericP-changes branch, which we'll PR into main/

danbri commented 1 year ago

This is main branch now, and github.io demo has been updated (and linked properly).

The SHACL version runs significantly slower, we need to figure out why, or at least add something in UI so people know that something is in progress.

There are also SHACL/ShEx differences in behaviour, will track that elsewhere.

SHACL is still fixed, so closing. /cc @ericprud @Gnomus042