search

google / schemarama

Schemarama is a project exploring standards-based validation for structured data, especially Schema.org.
Apache License 2.0
124 stars 22 forks source link

redux - update libraries and add github.io page as ericP@jd #43

Closed ericprud closed 1 year ago

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

danbri commented 1 year ago

We should delete these and start a fresh PR when your CLA situation is finalized. ok?

danbri commented 1 year ago

Ok I tried making a new PR with same content but it has canonicalized us back to this issue #43

I think I can get the CLA scan re-run, when the CLA is approved on your side.

At least the CLA failure here has the right committer ID:

The following contributors were found for this pull request: ❌ https://github.com/google/schemarama/commit/6d7f2be62fb47f309b89c67c2b846b1333d22c4e Author: @ericprud eric*********eaux​@janeirodigital.com

danbri commented 1 year ago

Schemarama's own tests were unhappy, but detailed logs have been purged already. How to re-run?

danbri commented 1 year ago

Seems like closing and re-opening PR is enough to re-run all tests. Ignore what it says in #41 about the ericP-changes branch having uncommitted changes - afaik they were all merged here.