search

google / secrets-gradle-plugin

A Gradle plugin for providing your secrets to your Android project.
Apache License 2.0
1.13k stars 99 forks source link

Remove misleading double quotes in local.defaults.properties file #46

Closed antonsurya closed 2 years ago

antonsurya commented 2 years ago

The local.defaults.properties file contains the following:

MAPS_API_KEY=""

I copied that line and added the following line in my local.properties:

MAPS_API_KEY="AIzaalskro0jlskdj2kr5jlksbjlksdjflkse0p"

where the AIza... is a valid API key.

With this configuration, when you run your app you will get an authentication error, because the whole string including the double quotes is $MAPS_API_KEY.

Please consider to remove the double quotes in local.defaults.properties because it may mislead people.

antonsurya commented 2 years ago

Hum, the comment above is actually for a sibling repo: https://github.com/googlemaps/android-samples/blob/main/ApiDemos/kotlin/local.defaults.properties, which uses this secrets Gradle plugin, but I think it would be good to address the issue also here. Let me know if you want me file an issue on the repo as well.

arriolac commented 2 years ago

Thanks for catching that! Will address this. Feel free to also send a PR