google / secrets-gradle-plugin

A Gradle plugin for providing your secrets to your Android project.
Apache License 2.0
1.13k stars 99 forks source link

Properties are not injected if the plugin is applied before the Android plugin #62

Open 0neel opened 1 year ago

0neel commented 1 year ago

If the plugin is added before com.android.application it silently skips properties injection. I believe it should fail the build in this case. Or, at least, docs should mention that the order is important. It took me several hours to understand why the properties are not injected when after some refactoring I accidentally changed the order of plugins.

jamesncl commented 1 year ago

Thank you, I also lost an hour chasing this until I found this issue. Agree that this should be documented or, fail the build with an explanatory error message, or otherwise fixed so that ordering is not important