search

google / secrets-gradle-plugin

A Gradle plugin for providing your secrets to your Android project.
Apache License 2.0
1.13k stars 99 forks source link

File leak in `loadPropertiesFile()` function within Extensions.kt #81

Closed pablobaxter closed 4 months ago

pablobaxter commented 4 months ago

This line causes a file leak that opens the given file each time a Gradle build is configured.

https://github.com/google/secrets-gradle-plugin/blob/16b9e729eb920017c00211e1c59837d7756f08cf/secrets-gradle-plugin/src/main/java/com/google/android/libraries/mapsplatform/secrets_gradle_plugin/Extensions.kt#L53C1-L53C50

wangela commented 4 months ago

Thanks for reporting the issue and providing a fix, @pablobaxter!