ncc.Dial() without ncc.Close() - Githubissues

google / seesaw

Seesaw v2 is a Linux Virtual Server (LVS) based load balancing platform.

Apache License 2.0

5.65k stars 511 forks source link

ncc.Dial() without ncc.Close() #48

Closed anfernee closed 4 years ago

anfernee commented 5 years ago

https://github.com/google/seesaw/blob/34716af0775ecb1fad239a726390d63d6b0742dd/engine/core.go#L311-L344

this will simply explode because it keeps calling L331 without Close() which gets deferred and never gets executed.

The ncc.Dial() and ncc.Close() pattern is odd.

It leaves the burden of dial/close to client
It does refcounting to save a connection to which I think is fine to keep the connection open.