Export stats struct/publisher interface for monitoring

google / seesaw

Seesaw v2 is a Linux Virtual Server (LVS) based load balancing platform.

Apache License 2.0

5.65k stars 511 forks source link

Export stats struct/publisher interface for monitoring #97

Closed DrJosh9000 closed 4 years ago

DrJosh9000 commented 4 years ago

Currently, exporting monitoring metrics would require patching the ecu package to add the necessary functionality. Exporting the types allows an implementation to provide a statistics publisher via the ECU config. This PR also makes a few changes to how ecu/stats.go operates.

liuyuan10 commented 4 years ago

could you squash all your commit into one? I don't see they need to be separate. https://www.internalpointers.com/post/squash-commits-into-one-git

liuyuan10 commented 4 years ago

@DrJosh9000 In case you missed it, please squash the commits into a single one in this RP as I said above. Thanks

DrJosh9000 commented 4 years ago

I did not miss your comment, and I've tried to do it (twice, with 6d7e073 and cc4c166), but it doesn't seem to have had the intended effect.

DrJosh9000 commented 4 years ago

Never mind, I needed to git push --force, apparently. TIL!