google / service-worker-detector

This extension detects if a website registers a Service Worker.
https://chrome.google.com/webstore/detail/service-worker-detector/ofdigdofloanabjcaijfidkogmejlmjc
Apache License 2.0
172 stars 24 forks source link

Document non-appearance of the icon #12

Closed grahamperrin closed 5 years ago

grahamperrin commented 5 years ago

https://github.com/google/service-worker-detector/issues/7#issuecomment-330342723 for example and more recently, https://addons.mozilla.org/addon/service-worker-detector/reviews/1161836/:

… Just installed this addon but it did not detect that Youtube installed a service worker. …

https://github.com/google/service-worker-detector/issues/9#issuecomment-391673085:

… the extension only triggers when navigator.serviceWorker.controller is no longer null, i.e., as soon as the service worker becomes active (documentation).

Suggestions

Update https://github.com/google/service-worker-detector/blob/master/README.md with a short simple explanation of why the icon does not appear in some situations. The opening paragraph is probably ideal, a handful of bullet points should suffice.

Add About this extension information to https://addons.mozilla.org/addon/service-worker-detector/ – include a link to README.md but people love to not follow links to documentation ;-/ so FWIW I reckon it's worth including a brief explanation, re: non-appearance of the icon, at the AMO page itself.


AFAICT (from The Air Horner example):

From some of the earlier issues I gather that in some cases, a first simple reload might not suffice, two reloads are necessary. True?

In some cases the worker will be active following a hard refresh e.g. Shift-reload or Control-F5. This seems to be true for The Air Horner.

In other cases the worker will not be active following a hard refresh. This seems to be true for the current worker for Gmail – scope https://mail.google.com/mail/u/0/

Side note

Mozilla bug 1495275 - Corrupted Content Error for gmail (I'm using Service Worker Detector, with Waterfox, in connection with this bug).

grahamperrin commented 5 years ago

… In other cases the worker will not be active following a hard refresh. This seems to be true for the current worker for Gmail …

Hmm, I just found the opposite. Contradicting myself. Given Mozilla bug 1495275, maybe Gmail is not a good example … sorry …

tomayac commented 5 years ago

Thanks, @grahamperrin!