search

google / sg2im

Code for "Image Generation from Scene Graphs", Johnson et al, CVPR 2018
Apache License 2.0
1.29k stars 230 forks source link

In the coco.py, some doubts about the objects' relationships #8

Open hawkwater opened 5 years ago

hawkwater commented 5 years ago

In the coco.py, line 337-348

if sx0 < ox0 and sx1 > ox1 and sy0 < oy0 and sy1 > oy1:
        p = 'surrounding'
elif sx0 > ox0 and sx1 < ox1 and sy0 > oy0 and sy1 < oy1:
        p = 'inside'
elif theta >= 3 * math.pi / 4 or theta <= -3 * math.pi / 4:
        p = 'left of'
elif -3 * math.pi / 4 <= theta < -math.pi / 4:
        p = 'above'
elif -math.pi / 4 <= theta < math.pi / 4:
        p = 'right of'
elif math.pi / 4 <= theta < 3 * math.pi / 4:
        p = 'below'

I have some doubts about the 'above' and 'below', i think they should be exchanged and the code is

elif -3 * math.pi / 4 <= theta < -math.pi / 4:
        p = 'below'
elif math.pi / 4 <= theta < 3 * math.pi / 4:
        p = 'above'
BupyeongHealer commented 2 years ago

@hawkwater I was doubt same as you. However, Actually, the original code is right becasue of the prior relationship between objects.