google / shaderc-rs

Rust bindings for the shaderc library.
https://docs.rs/shaderc
Apache License 2.0
261 stars 64 forks source link

make Compiler Send and Sync #122

Closed kocsis1david closed 2 years ago

kocsis1david commented 2 years ago

Fixes https://github.com/google/shaderc-rs/issues/113

I'm not 100% sure if this is safe. If not, this PR could be deleted.

It seems that the only reason shaderc::Compiler exists is to call glslang::InitializeProcess and glslang::FinalizeProcess, so it should be Send and Sync.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.