search

google / shaderc-rs

Rust bindings for the shaderc library.
https://docs.rs/shaderc
Apache License 2.0
261 stars 64 forks source link

Update submodules #128

Closed BeastLe9enD closed 1 year ago

BeastLe9enD commented 1 year ago

Hey, I updated all submodules, the tests run without error!

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

antiagainst commented 1 year ago

Thanks for the pull request (and sorry about the delay)! Looks there is an issue in shaderc. I filed a fix here: https://github.com/google/shaderc/pull/1280.

BeastLe9enD commented 1 year ago

What OS are you on? On Windows, everything works fine for me!

antiagainst commented 1 year ago

What OS are you on? On Windows, everything works fine for me!

It's the cross compilation build bots failing: https://github.com/google/shaderc-rs/actions/runs/3331419724/jobs/5898768267.

antiagainst commented 1 year ago

Hey @BeastLe9enD, https://github.com/google/shaderc/pull/1280 is landed in shaderc. If you can refresh it again (sorry about the trouble!), the tests should be passing I belive. Thanks!

BeastLe9enD commented 1 year ago

Yes, it should work now! Thank you!

Jerrody commented 1 year ago

I think that we can merge it!