search

google / shaderc-rs

Rust bindings for the shaderc library.
https://docs.rs/shaderc
Apache License 2.0
261 stars 64 forks source link

Do not link native library when cross compiling for docs #145

Closed marc0246 closed 9 months ago

marc0246 commented 9 months ago

This fixes #144 by only bailing out on the linking if cross-compilation is going on, which excludes build scripts and proc-macros. I really hate this solution, and I wish there was some other way to go about this, but at least this doesn't penalize any crates in the sense that the dependent library's author doesn't need to do anything. I just pray that this doesn't run into more unforseen complications.

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

marc0246 commented 9 months ago

Is there no way to sign the CLA without revealing my email address?

antiagainst commented 9 months ago

LGTM; but wanted to have @chyyran take a look too.

chyyran commented 9 months ago

lgtm

marc0246 commented 9 months ago

Can we please get a patch version bump?

antiagainst commented 9 months ago

Can we please get a patch version bump?

Sure; pushed a new release.

marc0246 commented 9 months ago

Awesome, thanks a lot!