Closed enfipy closed 3 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
ℹ️ Googlers: Go here for more info.
Thanks for adding this!! Could you rebase first? The buildbots failure is fixed at top of the tree. I'll take a look later. :)
Closes #87
I was able to run
shaderc-rs
on the Android app with dynamically linked shaderc that was built with thendk-build
tool insidebuild/shaderc/android_test
folder with the following command:Then I provide the path to the libs folder as
SHADERC_LIB_DIR
. I'm sure that this is not a good way to make it work but still - it works and I want to hear any feedback on how to make it right.Also, there's still not possible to build it with the
CARGO_FEATURE_BUILD_FROM_SOURCE
and without PITA while building it withndk-build
by yourself. Should I addndk-build
tobuild.rs
or there some way to do it withninja
?