search

google / shaderc

A collection of tools, libraries, and tests for Vulkan shader compilation.
Other
1.79k stars 343 forks source link

OGLCompiler and HLSL have been removed from glslang #1381

Closed juan-lunarg closed 7 months ago

juan-lunarg commented 7 months ago

This fixes SPIRV-Tools CI-shaderc-smoketest build failure.

juan-lunarg commented 7 months ago

See https://github.com/KhronosGroup/glslang/pull/3426 for details.

This PR should also address this shaderc smoke test build failure: https://source.cloud.google.com/results/invocations/788aa1a5-6dc1-433c-b07d-289e3b20e2b3/targets

[728/795] Linking CXX executable libshaderc_util/shaderc_util_format_test
FAILED: libshaderc_util/shaderc_util_format_test
: && /usr/bin/g++  -Wimplicit-fallthrough -O3 -DNDEBUG   libshaderc_util/CMakeFiles/shaderc_util_format_test.dir/src/format_test.cc.o  -o libshaderc_util/shaderc_util_format_test  libshaderc_util/libshaderc_util.a  lib/libgmock.a  lib/libgtest_main.a  third_party/glslang/glslang/libglslang.a  -lOGLCompiler  -lHLSL  third_party/glslang/SPIRV/libSPIRV.a  third_party/glslang/glslang/libMachineIndependent.a  third_party/glslang/glslang/OSDependent/Unix/libOSDependent.a  third_party/glslang/glslang/libGenericCodeGen.a  third_party/spirv-tools/source/opt/libSPIRV-Tools-opt.a  third_party/spirv-tools/source/libSPIRV-Tools.a  -lrt  -pthread  lib/libgtest.a  -lpthread && :
/usr/bin/ld: cannot find -lOGLCompiler
/usr/bin/ld: cannot find -lHLSL
dneto0 commented 7 months ago

Hm. This might fail because DEPS needs to be updated too.

juan-lunarg commented 7 months ago

Hm. This might fail because DEPS needs to be updated too.

Updated DEPS.

dneto0 commented 7 months ago

Closed in favour of #1384 Also needed an update to the docker script that tests the android build. The glslang-standalone target is not defined for Android (or iOS) anymore.

But thank you for getting this rolling!