2024.1 build failure - Githubissues

chenrui333 commented 7 months ago

👋 trying to build the latest release, but run into some build issue. The error log is as below:

error build log

``` CMake Error: install(EXPORT "glslang-targets" ...) includes target "SPIRV" which requires target "SPIRV-Tools-opt" that is not in any export set. ```

full build log, https://github.com/Homebrew/homebrew-core/actions/runs/8902764791/job/24449380653?pr=170490 relates to Homebrew/homebrew-core#170490

m154k1 commented 4 months ago

Removing this line works for me:

diff --git a/third_party/CMakeLists.txt b/third_party/CMakeLists.txt
index d44f62a..dffac6a 100644
--- a/third_party/CMakeLists.txt
+++ b/third_party/CMakeLists.txt
@@ -87,7 +87,6 @@ if (NOT TARGET glslang)
       # Glslang tests are off by default. Turn them on if testing Shaderc.
       set(GLSLANG_TESTS ON)
     endif()
-    set(GLSLANG_ENABLE_INSTALL $<NOT:${SKIP_GLSLANG_INSTALL}>)
     add_subdirectory(${SHADERC_GLSLANG_DIR} glslang)
   endif()
   if (NOT TARGET glslang)

ref: https://github.com/google/shaderc/commit/c78975365d9360951925288b24e6b0ac02a5d603

svenstaro commented 2 days ago

Can't this be closed?

google / shaderc

2024.1 build failure #1413