Shaderc build breaks due to mismatch SPIRV-Tools w.r.t. Glslang - Githubissues

google / shaderc

A collection of tools, libraries, and tests for Vulkan shader compilation.

Other

1.82k stars 354 forks source link

Shaderc build breaks due to mismatch SPIRV-Tools w.r.t. Glslang #417

Open dneto0 opened 6 years ago

dneto0 commented 6 years ago

Shaderc bots are broken because:

Shaderc builds are configured to use latest SPIRV-Tools
Glslang (and its tests) assume a specific version of SPIRV-Tools
Glslang golden test results are sensitive to SPIRV-Tools transforms
SPIRV-Tools transforms evolve.
So there can be a mismatch on Glslang test results in Shaderc's build bots.

The latest example is a recent improvement to block merging in SPIRV-Tools.

It's unclear how often this will occur. I'm keeping this open to document the issue, and to avoid a general panic. :-)

dneto0 commented 6 years ago

One thing I could do is to add specific glslang test files to Shaderc that override the base results from glslang itself.