search

google / shipshape

Program analysis platform
Apache License 2.0
271 stars 35 forks source link

"latest" image in our repository #106

Closed supertriceratops closed 9 years ago

supertriceratops commented 9 years ago

Attempting to build the container and then run shipshape. It appears the "docker pull" command pulled down a "latest" image from 4 months ago, presumably from our docker images repository.

clconway commented 9 years ago

Are you sure that "docker pull" with no version label isn't getting the image from your local repo?

supertriceratops commented 9 years ago

I am pretty sure that is not what is happening. To repro:

1) bazel build //shipshape/docker:service "docker images" now shows an image build a few seconds ago tagged latest for gcr.io/shipshape_releases/service 2) Run the shipshape cli with the argument --tag=latest. Now the image just built has been untagged, and there is a new gcr.io/shipshape_releases/service:latest built 4 months ago.

clconway commented 9 years ago

Shouldn't "latest" always implicitly take the newer/more local image? Did we accidentally push an image explicitly labeled "latest" to the repo? Looking at the repo, both "prod" and "staging" are newer than "latest".

supertriceratops commented 9 years ago

1) Apparently it does not do this. 2) I am pretty sure someone pushed an image labelled "latest"

ciera commented 9 years ago

There are lots of blog posts on the intarwebz dedicated to hatred of "latest" and the fact that it doesn't mean "latest". I've changed our build rules to remove it there. Will now figure out how to remove it from the repo itself.

ciera commented 9 years ago

I've deleted the tags from the registry, and also deleted the old "base" image.