search

google / shipshape

Program analysis platform
Apache License 2.0
269 stars 35 forks source link

Improve services health check #50

Open emsod opened 9 years ago

emsod commented 9 years ago

The Shipshape CLI fails every other time due to this error:

0625 20:40:50.884702 1312 shipshape.go:227] Error making service call: received an error from calling run: service needs to be called with triggered categories and/or a repo root with a valid .shipshape file with the event manual

May just be that the health check needs to wait longer.

ciera commented 8 years ago

Can we repro this?

emsod commented 8 years ago

I still see this error:

HTTP client did not become healthy: service did not respond before timeout: HTTP failure: Post http://localhost:10007/: dial tcp [::1]:10007: getsockopt: connection refused

This output is from running the CLI tests, and doesn't happen at every run. The failure wasn't there on the second run.

ciera commented 8 years ago

Running the old CLI tests, or the new ones? I still cannot repro.

ciera commented 8 years ago

ping?

ciera commented 8 years ago

I got this for the first time:

--- FAIL: TestChangingDirs (17.89s) shipshape_test.go:210: ParentDir: Failure on service call; err: HTTP client did not become h ealthy: service did not respond before timeout: HTTP failure: Post http://localhost:10007/: dial tcp [::1]:10007: getsockopt: connection refused