search

google / shipshape

Program analysis platform
Apache License 2.0
271 stars 35 forks source link

Shipshape analyzing symlinks #60

Open llbit opened 9 years ago

llbit commented 9 years ago

Shipshape seems to be sending requests to analyze symlinks to my standalone analyzer. When I run shipshape on itself it sends requests to analyze bazel-bin (shouldn't this be ignored in .shipshape?), and tools/defaults. These are both symlinks in the shipshape directory, so maybe they did not get copied over to the docker volume.

Is this intended, or should Shipshape ignore symlinks instead?

emsod commented 9 years ago

https://phabricator-dot-shipshapecode.appspot.com/D54 adds ignoring of symlinks.

rsamuelklatchko commented 9 years ago

Blocking all symlinks feels overkill.

clconway commented 9 years ago

filepath.Walk() always ignores symlinks, so I'm not sure if 3cf7aa9 even does anything.

clconway commented 9 years ago

@rsamuelklatchko Pointed out offline that 3cf7aa9 does succeed in ignored symlinked files. filepath.Walk() won't recurse into symlinked directories. Still, that doesn't explain why @llbit saw Shipshape analyzing bazel-bin.

llbit commented 9 years ago

@clconway the .shipshape file was updated in b35a9a9d594cedfee1ccc543ad3578875555d405 to ignore bazel-bin.