search

google / shipshape

Program analysis platform
Apache License 2.0
271 stars 35 forks source link

Upgrade campfire #9

Closed schroederc closed 9 years ago

schroederc commented 9 years ago

This upgrades campfire to version 8c49de9a5408808a7c03e7728b7e2da1c83ec00c from http://www.github.com/google/kythe with some changes so fit in Shipshape's existing usages. Changes include removing kythe_rules.js, fixing buildtools paths, fixing CAMPFIRE files to use go_test rule, and changing go_external_lib rule implementation to fit with existing usages.

The new campfire engine requires ninja >=1.5 to be installed and will used the version in third_party/ninja, by default.

supertriceratops commented 9 years ago

Why do you have the ninja source code in third_party? Do you build and use this for Kythe? Do you also have a ninja binary checked in? Are there other things we should be updating in third_party? What is your story for OSX?

schroederc commented 9 years ago

It's in our third_party directory so that we don't rely on the system's version. It's a pre-built binary.

You'll need to update some of your third_party libraries if you wish to update your Kythe sources.

OSX: http://kythe.io/phabricator/T3

supertriceratops commented 9 years ago

LGTM