Open ciera opened 9 years ago
How about the Docker test image? https://github.com/google/shipshape/tree/master/shipshape/test/docker Is Docker-in-Docker too much of a pain to set up?
I think Sam was working on this...
On Tue, Sep 29, 2015 at 9:58 AM, clconway notifications@github.com wrote:
How about the Docker test image? https://github.com/google/shipshape/tree/master/shipshape/test/docker Is Docker-in-Docker too much of a pain to set up?
— Reply to this email directly or view it on GitHub https://github.com/google/shipshape/issues/93#issuecomment-144120166.
How close does this get us? https://cloud.google.com/cloud-shell It's got Docker, Go, Git, etc. Not clear if they support custom base images, but we could also just pull the image from #94.
+scpayson
On Mon, Oct 5, 2015 at 9:27 AM, clconway notifications@github.com wrote:
How close does this get us? https://cloud.google.com/cloud-shell It's got Docker, Go, Git, etc. Not clear if they support custom base images, but we could also just pull the image from #94 https://github.com/google/shipshape/issues/94.
— Reply to this email directly or view it on GitHub https://github.com/google/shipshape/issues/93#issuecomment-145591170.
Oops (this is scpayson),
I am in fact working on this. Current status is that I've got a working image and now I'm automating the process of creating one.
In order to create a VM from the image at the moment (from our test GCE project), you create an instance as usual, and then when configuring the Boot Image section choose the "Your Image" tab at the top and select "shipshape-prefab".
I have also succeeded in exporting this so that we can distribute the image.
Thanks Sam. I think the steps remaining are:
1) Make the image publicly available 2) Modify the instructions here: https://github.com/google/shipshape/blob/master/shipshape/docs/add-an-analyzer.md 3) Check in the script used to create the image, and add it to our release process.
Also, just tested out the image. A couple items: 1) I notice that git is installed, which is good! I hadn't even thought of that. 2) Docker seems to be installed, but it requires sudo. The following two commands are supposed to fix that, though I can't get the second to work. Can you investigate and update the script? sudo usermod -G docker $USER sudo service docker.io restart
Actually, just learned the second command isn't necessary at all, just requires logging out and logging in again. I'll update our docs on that.
There is a 'shipshape-user' user who is already in that group. I will push docs shortly which mention this (users can also add themselves to the group if they don't want to use shipshape-user).
I think for the analysis writers especially, we should make that the default. We want people to get up and running with as few steps as possible.
It's a huge pain to install all the dependencies for a developer who just wants to experiment a bit. Instead, let's create a GCE image that has everything one needs.