search

google / simhospital

Apache License 2.0
666 stars 76 forks source link

Bump rules_docker to 0.25.0 #14

Closed sonjoonho closed 1 year ago

sonjoonho commented 1 year ago

At current HEAD, running bazel run //cmd/simulator:simulator gives the error

ERROR: /home/joon/.cache/bazel/_bazel_joon/9c9f4b45750f8adb97f0298f4dc9193a/external/bazel_tools/platforms/BUILD:59:6: in alias rule @bazel_tools//platforms:osx: Constraints from @bazel_tools//platforms have been removed. Please use constraints from @platforms repository embedded in Bazel, or preferably declare dependency on https://github.com/bazelbuild/platforms. See https://github.com/bazelbuild/bazel/issues/8622 for details.
ERROR: /home/joon/.cache/bazel/_bazel_joon/9c9f4b45750f8adb97f0298f4dc9193a/external/bazel_tools/platforms/BUILD:59:6: Analysis of target '@bazel_tools//platforms:osx' failed
ERROR: /home/joon/Projects/simhospital/cmd/simulator/BUILD.bazel:38:10: While resolving toolchains for target //cmd/simulator:simulator: invalid registered toolchain '@io_bazel_rules_docker//toolchains/docker:default_osx_toolchain': 
ERROR: Analysis of target '//cmd/simulator:simulator' failed; build aborted: 
INFO: Elapsed time: 1.533s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (2 packages loaded, 0 targets configured)
ERROR: Build failed. Not running target

Updating the version of rules_docker fixes this.

This also means we can remove pip_deps (see https://github.com/bazelbuild/rules_docker/pull/1657).

taraojo commented 1 year ago

Merged, thanks @sonjoonho!