Display snippet status alongside connected status in "Connected Services" tab

[jamesozzie]

Feature Description

Consider adding a notice to display the snippet status for the Analytics, AdSense and Tag Manager modules.

At present a user may have used another Analytics plugin to place the tracking code. For that reason they may have opted out of allowing Site Kit to place the snippet. They may then have decided to solely use Site Kit, while deactivating the other plugin. This can result in data not being collected on their site until they go back and toggle the Site Kit option to insert the snippet.

Rather than just state "Analytics is connected" it may be useful to add the snippet status alongside the connected status. "Analytics is connected - Snippet inserted"

Likewise with the AdSense and Tag Manager modules.

Without the above there have been cases whereby users are not aware their site didn't have the required snippet.

https://wordpress.org/support/topic/analytics-code-is-not-showing/ https://wordpress.org/support/topic/recover-missing-data/

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

QA Brief

Changelog entry

[odedta]

Please add this! thanks!

[aaemnnosttv]

@felixarntz @marrrmarrr perhaps we could add an additional icon for this (e.g. </>) since the current text is redundant when we have the green checkmark. Maybe the text could move to a tooltip?

[marrrmarrr]

@aaemnnosttv would there ever be a case where the snippet is inserted but the service is not connected? If not, then we can rephrase this everywhere to "$PRODUCT snippet is inserted".

[aaemnnosttv]

@marrrmarrr maybe for AdSense since I think the snippet needs to be output before setup can be completed 🤔 (@felixarntz ?)

"connected" here is essentially means "set up complete", which is useful to show since this list will show all active modules (whether setup has been completed or not). It is very much possible for a module to be set up, without the snippet inserted since we have a setting for that but also in the case of an existing tag.

I think the "{product} is ___" text on the item is maybe unnecessary, although it does fill in some space that would otherwise be empty. Showing multiple indicators there would be a bit more useful, as long as it wasn't confusing which is where an added tooltip might help.

Maybe @aarondruck has some ideas for patterns to use in this situation?

[aarondruck]

Can we just make it an absolute state?

So a service can only be connected, if set up is complete AND a snippet is inserted?

On Fri, Apr 16, 2021 at 1:22 AM Evan Mattson @.***> wrote:

@marrrmarrr https://github.com/marrrmarrr maybe for AdSense since I think the snippet needs to be output before setup can be completed 🤔 ( @felixarntz https://github.com/felixarntz ?)

"connected" here is essentially means "set up complete", which is useful to show since this list will show all active modules (whether setup has been completed or not). It is very much possible for a module to be set up, without the snippet inserted since we have a setting for that but also in the case of an existing tag.

I think the "{product} is ___" text on the item is maybe unnecessary, although it does fill in some space that would otherwise be empty. Showing multiple indicators there would be a bit more useful, as long as it wasn't confusing which is where an added tooltip might help.

Maybe @aarondruck https://github.com/aarondruck has some ideas for patterns to use in this situation?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/site-kit-wp/issues/1292#issuecomment-821008665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAURNSSO4OXKTFZZJAI3VRDTI7XUBANCNFSM4LUC53IQ .

[aarondruck]

Also, is this related: https://github.com/google/site-kit-wp/issues/2817

On Mon, Apr 19, 2021 at 1:59 PM Aaron Druck @.***> wrote:

Can we just make it an absolute state?

So a service can only be connected, if set up is complete AND a snippet is inserted?

On Fri, Apr 16, 2021 at 1:22 AM Evan Mattson @.***> wrote:

@marrrmarrr https://github.com/marrrmarrr maybe for AdSense since I think the snippet needs to be output before setup can be completed 🤔 ( @felixarntz https://github.com/felixarntz ?)

"connected" here is essentially means "set up complete", which is useful to show since this list will show all active modules (whether setup has been completed or not). It is very much possible for a module to be set up, without the snippet inserted since we have a setting for that but also in the case of an existing tag.

I think the "{product} is ___" text on the item is maybe unnecessary, although it does fill in some space that would otherwise be empty. Showing multiple indicators there would be a bit more useful, as long as it wasn't confusing which is where an added tooltip might help.

Maybe @aarondruck https://github.com/aarondruck has some ideas for patterns to use in this situation?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/google/site-kit-wp/issues/1292#issuecomment-821008665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAURNSSO4OXKTFZZJAI3VRDTI7XUBANCNFSM4LUC53IQ .

[aarondruck]

Ok I left some feedback in Figma

On Tue, Apr 27, 2021 at 8:45 AM Felix Arntz @.***> wrote:

Assigned #1292 https://github.com/google/site-kit-wp/issues/1292 to @aarondruck https://github.com/aarondruck.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/google/site-kit-wp/issues/1292#event-4651688130, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAURNSSZ7CSVW3R77VPXF4DTK3L3NANCNFSM4LUC53IQ .

[tofumatt]

I'm going to move this out of stalled because it seems a useful feature, and even adding aria-label and title attributes to the green icon when connected, then using the text to signify if the snippet is inserted or not, would be a usability win here.

Let's add some ACs that can alert the user only when a snippet isn't inserted, and see about removing the redundant "$PRODUCT is connected" text for at least the connected state.