search

google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

Add context to the "Let Site Kit place code on your Site" configuration option within Tag Manager #2583

Open jamesozzie opened 3 years ago

jamesozzie commented 3 years ago

Bug Description

With the Tag Manager configuration there is a "Let Site Kit place code on your site" toggle option. As toggling this off results in no Tag Manager snippet it works similar to disconnecting the Tag Manager module.

To ensure users are aware of the consequences of toggling this off consider including additional context to this toggle, informing users that any tags or functionality applied within the connected container will be redundant, this includes Analytics if applied via Tag Manager.

An alternative approach to make it more clear of the consequences is to remove this configuration option, with "Disconnecting" the Tag Manager module more obvious to users that their Tag Manager snippet will no longer be inserted.

image

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

Visual Regression Changes

QA Brief

Changelog entry

jamesozzie commented 3 years ago

@marrrmarrr Do you want to take a look at the existing workings for this toggle?