Show tooltip tours on smaller screen sizes (depends on upstream package updates)

tofumatt commented 3 years ago

Feature Description

Currently we disable our tooltip tours on smaller viewports—see https://github.com/google/site-kit-wp/issues/2739#issuecomment-804106445. This is because the upstream package has issues with absolutely-positioned elements as documented in this issue with React Joyride: https://github.com/gilbarbara/react-joyride/issues/594

Once that is fixed let's enable the tooltip tours at lower screen widths and see if the issues with smaller screen sizes (reported in https://github.com/google/site-kit-wp/issues/2739#issuecomment-803206549) are still there.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

The tooltip tours should appear at all screen sizes, not just ones larger than mobile.

Implementation Brief

Upgrade react-joyride to use minimum version 2.7.2, that has https://github.com/gilbarbara/react-joyride/issues/594 closed.
Remove code that disables the tooltip tours on mobile/small screens. Essentially, remove the code added in #3004.

Test Coverage

N/A

Visual Regression Changes

Tooltip tours will appear at smaller screen sizes now—not just desktop. This likely won't affect VRT but highlighting here as an obvious visual change.

QA Brief

Changelog entry

tofumatt commented 9 months ago

This one is stalled by https://github.com/gilbarbara/react-joyride/issues/594 being closed. When it is closed we can revisit this one.

tofumatt commented 3 months ago

Update: this was fixed in 2.7.2 of react-joyride: https://github.com/gilbarbara/react-joyride/issues/594#issuecomment-1868333873

I'll move this out of stalled and into IB, it's possible the existing IB is sufficient but it's worth checking again as it's been a bit of time 🙂

benbowler commented 2 months ago

I picked this up and tested 2.7.2 of react-joyride, it causes a build failure:

[Can't import the named export 'Component' from non EcmaScript module (only default export is available)](https://github.com/gilbarbara/react-joyride/issues/972#top)

So we'd likely need some updates to webpack to use this update. We currently don't have a multi step tour to test this currently, the dashboard sharing tour only has a copy of steps.

google / site-kit-wp