google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

Extend issue templates with config #3432

Closed aaemnnosttv closed 1 year ago

aaemnnosttv commented 3 years ago

Feature Description

Currently we have a few issue templates for creating a new issue for a bug or feature request, but GitHub also supports adding additional links via a configuration file.

E.g. https://github.com/ampproject/amp-wp/issues/new/choose

We should leverage this to add useful links in a similar way, as well as maybe add a new template or two.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

Visual Regression Changes

QA Brief

Changelog entry

aaemnnosttv commented 2 years ago

@felixarntz I added some initial ACs. Sending your way for more details 🙂 cc: @marrrmarrr

felixarntz commented 2 years ago

@aaemnnosttv Hmm this seems like it may benefit from a bit more definition overall? I agree it might be good to add the two links, and we can define wording about that, but what about leveraging forms for actual issues like bug reports etc? Maybe we scope this one more specifically to providing helpful links in GitHub issue UI, following what you already added to the ACs?

@marrrmarrr It'd probably be best for you to define the wording here, let's have a look later this week.

aaemnnosttv commented 2 years ago

what about leveraging forms for actual issues like bug reports etc?

@felixarntz my initial thought is that this isn't as relevant for us as issues for bugs are either opened by us or the support team, so forms wouldn't be as useful I don't think. These are a new beta feature that I haven't seen used yet so maybe there is more utility to using them, I'm not really sure.

felixarntz commented 2 years ago

Sounds good, I agree we should keep things basic for now. Maybe still worth opening an issue for the Backlog to go further at some point - it may make things easier for external folks.

mxbclang commented 1 year ago

@felixarntz @marrrmarrr This is a really old one – is this still relevant, and if so, how can we move forward? Thanks!

aaemnnosttv commented 1 year ago

@bethanylang still relevant, yes – will pick up in an upcoming sync

jimmymadon commented 1 year ago

@adamdunnage @marrrmarrr Have filled in the about sections with pieces I've found in our support posts. Could you please review these copies? Thank you.

tofumatt commented 1 year ago

QA ✅

New text/links appear in the GitHub "New issue" page:

CleanShot 2023-11-02 at 19 29 15

Bonus to @jimmymadon for including emoji 🥇