google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 286 forks source link

"Data flow in Site Kit" #3454

Open eclarke1 opened 3 years ago

eclarke1 commented 3 years ago

Feature Description


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Instead of a regular IB, please provide your proposed document outline (nested list of headings) for the article here. Use headings that the article could actually use, not just some brainstorm type of preliminary heading. Please assign to @felixarntz for IB review, specifically since this is one of the first articles in the epic.

Test Coverage

QA Brief

Changelog entry

eclarke1 commented 3 years ago

@felixarntz @aaemnnosttv @marrrmarrr this was one of the 4 articles voted highest priority by engineers so if possible to progress this through the workflow along with the others labelled 'Type: Docs' and have P1 assigned.

felixarntz commented 2 years ago

@eugene-manuilov IB mostly looks good, however I have one concern:

and explain in detail how createFetchStore works and how users can create their own fetch stores

This should be part of the referenced "Data store architecture" docs instead. The article here should focus more on high-level concepts and doesn't need to go into actual code as much - it's the first article in the Architecture section, so it's more important to explain the flow, the relationships of different pieces, maybe naming conventions, etc. We don't need to cover how exactly to write the client-side and server-side parts of an endpoint here - it's okay to use code pointers, but the article itself shouldn't focus on code.

Other than this one point, I think the outline looks solid.

eugene-manuilov commented 2 years ago

@felixarntz, IB is updated. Does it look better?

felixarntz commented 2 years ago

@eugene-manuilov Looks good, IB ✅

aaemnnosttv commented 1 year ago

@tofumatt left a few comments here but overall I think it's good to go. I'm also happy for someone else to give it a final look over to not be a blocker here if you'd like, but this can probably also be a quick final review from me before merging.