google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 284 forks source link

Improve workflow for creating and connecting a new GA4 property on a connected Analytics account #3586

Closed mxbclang closed 3 years ago

mxbclang commented 3 years ago

Feature Description

The current workflow for a user who already has an Analytics account and UA property connected in Site Kit and wants to add and connect a new GA4 property is pretty confusing at the moment. Video here: https://jmp.sh/sr0X43j+/Screen+Recording+2021-06-15+at+4.18.10+PM.mp4.

It would be great to streamline and make this workflow more user-friendly, as I think we'll get a lot of folks in support who are new to GA4 and will want to create a new property for it, but won't have any idea where to start based upon the current flow, and will be confused once they get into the Settings.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Note: The above requirements were what was originally envisioned for how to handle existing sites, it looks like this somehow got lost in definition / engineering. We should not, for now, prompt existing users about GA4 unless they go through setup. This will be changed in a more appropriate way later.

Implementation Brief

Test Coverage

Visual Regression Changes

QA Brief

Changelog entry

felixarntz commented 3 years ago

@bethanylang Thanks for raising this, those are great points. Leaving an initial reply to your three points:

  1. The idea was not to immediately prompt users that already have Analytics set up. We first want to focus on new users or those who set up the module anyway. There's still a long time left (last prediction was 2023) until UA properties are no longer supported, so we don't need to catch everyone just yet. The long-term approach is definitely a prompt like you're suggesting.
  2. Agreed, I think this is what we should focus on for this issue. The notices in the Analytics settings should probably use an alternate copy to clarify the situation. You've also touched on this in #3584.
  3. This is due to a technical problem which has already been relevant in any other situation when you create new entities from any module settings panel (e.g. also when you choose to create a new UA property in the current Analytics settings UI). Fixing this is probably something we should have a follow-up issue for, but it's technically quite the challenge, so we haven't been able to prioritize this yet. So while I agree this is a problem, it is not new, so I think we should look into this separately. There has been one other problem related to this (#3550), but it looks like you didn't encounter that one. Due to the limitation, the current expected behavior is the following:
    1. You attempt the action (submit the form).
    2. Because it requires additional permissions on Google, you see a dialog with a link that redirects you to the Google OAuth consent screen, to grant the additional permissions.
    3. Then you arrive back in the plugin, in the same state that you were in before. You now have to re-submit the form, at which point this will work.

The preferred way to make point 3. work is that instead of requiring to re-submit the form the form automatically re-submits itself once you arrive back in the plugin. But as mentioned above, this is a general complex problem, which I think would be better handled in its own issue.

Let me know your thoughts!

mxbclang commented 3 years ago

@felixarntz Thank you for laying this all out! My thoughts below:

The idea was not to immediately prompt users that already have Analytics set up. We first want to focus on new users or those who set up the module anyway. There's still a long time left (last prediction was 2023) until UA properties are no longer supported, so we don't need to catch everyone just yet. The long-term approach is definitely a prompt like you're suggesting.

Fair enough! That said, as we have had a fair volume of users that have been requesting this feature, it might be nice to let them know in-product that it's now available. Maybe just something on the Analytics page?

Agreed, I think this is what we should focus on for this issue. The notices in the Analytics settings should probably use an alternate copy to clarify the situation. You've also touched on this in #3584.

šŸ‘

The preferred way to make point 3. work is that instead of requiring to re-submit the form the form automatically re-submits itself once you arrive back in the plugin. But as mentioned above, this is a general complex problem, which I think would be better handled in its own issue.

Agreed and understood. Let me know if you'd like me to create a separate issue for this.

In the interim, I'm drafting the documentation now that will specifically call out the need to click Confirm Changes again to see that GA4 has been successfully added.

aaemnnosttv commented 3 years ago

IB āœ…

wpdarren commented 3 years ago

QA Update: Pass āœ…

image

image