Closed felixarntz closed 2 years ago
@asvinb The IB is almost good to go, except for one thing: Wherever we add isGatheringData
checks for analytics
, we need to make sure they only run if the analytics
module is also active and connected. That limitation, which especially is relevant for assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/index.js
where none of those checks are present is currently missing from the IB. In that file, if analytics
isn't active and connected, the request shouldn't be made so it shouldn't impact the component's "loading" state.
Thanks @felixarntz . IB updated!
IB ✅
@hussain-t @aaemnnosttv I would like some clarification on the last point of the QAB:
Similarly if the Analytics is in gathering data state. Verify the blue CTA for Analytics gathering data should be rendered.
I have a scenario where there is either zero data or actual data in search console, but the SearchFunnelWidget
(Search traffic over the last 28 days) is not appearing when Analytics is connected and gathering data. I would have expected to see the Search Console data and a gathering data box where the analytics date is shown. Am I missing something?
This is what I see in 'Traffic' on a site where it has a new Analytics account, but has search console data.
This is what I see in 'Traffic' on a site that has an Analytics account with data and search console data.
@aaemnnosttv @tofumatt I've gone through thee QABs again on this one, and have found a scenario where Analytics has zero data and search console is gathering data. It's not really covered in the QAB, but in this situation I would expect to see the zero data on the search funnel for Analytics, and gathering data box for Search console.
This is basically the opposite of the issue reported yesterday, which is now fixed.
@wpdarren If Search Console is gathering data only Search Console Gathering Data
CTA will be rendered, nothing else.
In other words, Overview
component (that contains Analytics data) will only ever be rendered if Search Console is not gathering data.
Please refer to @aaemnnosttv's comment on the PR. ~I will update the QAB~ I have updated the QAB.
Thanks!
Verified:
When there is no Search Console data to display (to clarify: "zero data", not "gathering data"), the Search Funnel widget still shows the legacy blue CTA - which per #4085 and #4086 should only be shown if the service is actually gathering data. This should be fixed - it is especially problematic in the case that Analytics isn't activated yet, in which case that CTA will not be shown either.
In other words, the below UI should only be shown if Search Console is actually gathering data. Currently, it is also being shown when Search Console report has zero data, regardless of the "gathering data" situation.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
SearchFunnel
widget should be adjusted so that it only renders in the "blue zero data box" state if the Search Console report is zero and Search ConsoleisGatheringData
.isGatheringData
, render the blueReportZero
component in there, similar to the Analytics CTA, in place of the Analytics-specific tabs which therefore cannot be accessed.Implementation Brief
assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/Overview.js
,search-console
andanalytics
data store separately via theisGatheringData
selector to see if the data is being gathered for each module.true
and the report data is zero (via theisZeroReport
function fromassets/js/modules/search-console/util/is-zero-report.js
), renderWidgetReportZero
, withsearch-console
as value for themoduleSlug
prop.WidgetReportZero
component should be rendered in place of the first 2 data blocks (which are Search Console specific), similar to how it's done for Analytics.false
when using theisGatheringData
selector.WidgetReportZero
by adding whether the result from theisGatheringData
selector istrue
.assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/index.js
,search-console
andanalytics
data store separately via theisGatheringData
selector to see if the data is being gathered for each module.analytics
data store via theisGatheringData
selector, check if the analytics module is active and connected, similar to how it's being done foranalyticsOverviewLoading
. IfisAnalyticsConnected
isfalse
, returnfalse
.undefined
, render thePreviewBlock
similar to how it's being done today.WidgetReportZero
and associated logic to render it.assets/js/modules/search-console/components/dashboard/SearchFunnelWidget/index.stories.js
, update stories for cater for above scenarios.Test Coverage
QA Brief
Go to the Site Kit dashboard
Verify If Search Console is gathering data
Only
Search Console Gathering Data
CTA will be rendered, nothing else.Verify
Overview
component (that contains Analytics data) will only ever be rendered if Search Console is not gathering dataVerify if the Analytics is in gathering data, the blue CTA for Analytics gathering data should be rendered
QA:Eng - Verify the newly added stories
Analytics Gathering Data
andSearch Console Zero State
for theSearchFunnelWidget
component have the CTA renderedChangelog entry