google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 290 forks source link

Change CTA placement for Search Funnel on mobile #4695

Closed tofumatt closed 2 years ago

tofumatt commented 2 years ago

Feature Description

Currently, when Analytics is not connected (or when no Goals are setup for Analytics), the Search Funnel shows the CTA between the "Total Impressions" and "Total Clicks" metrics and the chart:

CleanShot 2022-01-21 at 01 44 21

As part of the Zero States epic, the CTA for Search Funnel on mobile should be moved below the chart:

CleanShot 2022-01-21 at 01 42 19

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

felixarntz commented 2 years ago

@tofumatt I marked this as blocked by #4694. The order doesn't really matter, but I think it makes sense to block one by the other to avoid conflicts.

asvinb commented 2 years ago

@tofumatt Can you clarify what you meant by the following?:

If Analytics is connected but the Goals CTA should appear, then it makes more sense to show the Goals CTA in the normal place (otherwise we'll have two half-width rows)

tofumatt commented 2 years ago

So there are two Analytics CTA states. One is when Analytics isn't connected at all, and it takes up two <DataBlock /> and is "full-width" on mobile:

CleanShot 2022-02-01 at 19 19 30

The other is when Analytics is connected, but you don't have any goals:

CleanShot 2022-02-01 at 19 17 47

For the first one (Analytics not connected), the Figma mocks show the CTA below the chart, which I think is good and we want to implement.

But in the case of the second one, we want a CTA that just shows one chart and mentions connecting goals, and should maintain the layout used in the second screenshot.

eugene-manuilov commented 2 years ago

IB :heavy_check_mark:

hussain-t commented 2 years ago

@tofumatt @asvinb there is another case where Analytics is active but not connected. Hence the Search Funnel shows the CTA between the "Total Impressions" and "Total Clicks" metrics and the chart:

Screenshot 2022-03-09 at 4 15 35 PM

What do we do in this case?

tofumatt commented 2 years ago

I'm not sure we have a design for that, but there's sort of two schools of thought there:

  1. Keep it where the CTAs are, because that's "consistent"
  2. bring it up higher to draw attention to the half-way setup

I'm actually for the second option (eg. leaving it as it is), because this isn't a CTA to encourage users, it's more of a notice that they didn't quite complete setup and still have more to do.

That said, it's pretty minor. It's probably easier code-wise to always have the CTA to connect and the CTA to complete setup in the same place. If that's the case let's always put them in the same spot. That might make it easier for QA too.

So let's say the CTAs should always appear below the chart, including the "complete activation" CTA.

Let's keep that CTA where it is actually, because it makes sense to make it more prominent. I've noted that in the ACs 👍🏻

hussain-t commented 2 years ago

Thanks, @tofumatt. I agree with leaving it as it is now. Moving it below the chart requires some style tweaks since the CTA overlaps the below widget.

wpdarren commented 2 years ago

QA Update: ✅

@hussain-t @tofumatt I have passed this but did wonder why we still have the blue to complete Analytics setup CTA? Is this worth including in a separate ticket to make the UI look like more like the activate analytics/goals CTA. I can see it was discussed here. Thoughts?

Verified:

Screenshots ![image](https://user-images.githubusercontent.com/73545194/157864352-f6eccbe4-fcd2-4241-9ae8-74d0de047cbb.png) ![image](https://user-images.githubusercontent.com/73545194/157864370-1d94b270-5d13-490d-90f5-50faca914467.png) ![image](https://user-images.githubusercontent.com/73545194/157864396-2135fa68-838f-4e80-b2dd-c1cc6c699a10.png)
felixarntz commented 2 years ago

invalid