Closed mohitwp closed 2 years ago
@marrrmarrr @aaemnnosttv I'm not sure how much this is actually an issue. I tend to agree it looks off, but also, this is still the active tab at this point, even though the user can't click any of them. The graph below relates to this number, not the other three ones.
I'm not sure what the best approach here is, I'd say completely removing it would be wrong. Maybe we can also gray out this line though, to better indicate it's not clickable while still keep the notion of it being active?
@felixarntz if the active tab isn't changeable I think graying out the line would be appropriate to indicate it's disabled. If we keep it blue, I'd argue maybe the user should be able to still select the other tabs of the search funnel widget.
@aaemnnosttv Makes sense. I agree, we should gray it out if the user cannot select anything else, but if e.g. only Analytics is gathering data but Search Console isn't (i.e. the two Search Console tabs are still selectable), it should remain blue.
@felixarntz what about when SC is gathering data and Analytics is not setup yet? Are the current ACs only relevant when Analytics is active?
@aaemnnosttv Ah, good point, I missed that. Updating the ACs now.
Works for me 👍🏻
IB ✅
@techanvil while reviewing the remaining issues for the sprint today, we identified this one as a nice-to-have issue to get into the release – if possible. It's still not any more important than it was, but it's the only one left in the sprint that would add value to the release.
Verified
Bug Description
While analytics is in gathering state, under 'Search traffic over the last 28 days' widget the first data block has the thick border. In gathering state 'Total Impression', 'Total clicks', 'Total impressions' or 'Unique visitors from search' from the SearchFunnel widget are not clickable, hovered or tabbable. It should follow the same design as the disabled pie chart tabs and have a grey colour.
Steps to reproduce
Screenshots
Additional Context
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/sass/components/global/_googlesitekit-data-block.scss
, setbackground-color: $c-jumbo
andopacity: 0.6
for.googlesitekit-plugin .googlesitekit-data-block--is-gathering-data.googlesitekit-data-block--selected::before
Test Coverage
QA Brief
Changelog entry