Revise Submit button wording for the final step in saving module settings

[wpdarren]

Bug Description

This was identified during the bug bash by James, as a post launch issue for AdSense Setup Improvement. If a user has an approved AdSense account and their site is also approved (ready) they'll be prompted to "Configure AdSense", before the service is connected. As there isn't any configuration applicable consider changing the wording to "Connect AdSense" or "Complete setup".

Recording of experience here.

Asana ticket can be found here https://app.asana.com/0/1202175292782289/1202322830239183/f

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Update the wording of the button which finishes a successful setup for all of our modules, ie. Google Analytics, AdSense and Tag Manager to say "Complete setup" (instead of "Configure " or "Confirm & Continue").

Implementation Brief

• Within assets/js/modules/analytics/components/setup/SetupForm.js, assets/js/modules/analytics/components/setup/SetupForm.js (if #7929 is already merged), assets/js/modules/adsense/components/setup/SetupAccountSite/Ready.js and assets/js/modules/tagmanager/components/setup/SetupForm.js:
  • Change the submit button text to what is in the AC instead of Configure Analytics, Configure AdSense and Confirm & Continue.

Test Coverage

• No new tests required but update VRT reference images and JS test snapshots as required.

QA Brief

• Set up Site Kit.
• Set up the Analytics, AdSense, and Tag Manager modules.
• In the setup screen for each of these modules, verify that the setup form's submit button says "Complete setup" as the wording.

Changelog entry

• Update setup buttons to use consistent language.

[ivonac4]

@marrrmarrr Are you still planning to review this soon? If not, can you please unassign yourself so someone else can pick up? Thank you!

[ivonac4]

@marrrmarrr Sorry, I misread the comments here, I realize now it is on you to review it. Do you mind taking a look at it when you have time? Thanks!

[eugene-manuilov]

• Update the wording of the button which finishes a successful setup for both, Google Analytics and AdSense to say "Complete set up" (instead of "Configure ").

@aaemnnosttv, I am not sure that we should change the button label for the Analytics setup form here. The intention of this ticket is to adjust the language for the AdSense setup process to have a more accurate button label when the actual configuration of the AdSense module is already completed and we need to do the final step to connect the module. In the Analytics module the setup flow is different and has only one step to save configuration and having the "Configure Analytics" label makes sense to me. What do you think?

[jimmymadon]

@eugene-manuilov My main reason to use "Complete set up" is that if the "next step" is going to be a "Success Banner", then saying "Configure XX" makes it look like there are more steps involved and that some users might not want to continue. In all "wizards", the last step is always clear with an action button like "Finish" that conveys that there are no more steps involved.

[jamesozzie]

@eugene-manuilov @aaemnnosttv The difference with the AdSense module "Configure..." label compared to the Analytics module, is that you are configuring Analytics. There are no configurations applicable when setting up AdSense. See below images:

AdSense module setup - No configurations applicable

Analytics module setup - Configurations can be applied on this screen

Considering there are AdSense configurations (screenshot), maybe we could allow configuration on this screen, at least the option to enable/disable ads for logged in users.

Maybe we could hold off on this issue and allow users to select AdSense configurations on this initial setup screen? I'm happy to open an issue for this if so.

[jimmymadon]

@jamesozzie Even though we are "configuring" some settings on the screen we are on, the CTA could convey clearly the message that there is no "further" configuration to be done and this is a "Save and Finish" situation. c.c. @sigal-teller

[aaemnnosttv]

I am not sure that we should change the button label for the Analytics setup form here

@eugene-manuilov I didn't include Analytics in the original AC :)

@jimmymadon if we're going to go beyond only AdSense here, the name of the issue should probably be updated to reflect that. I'm not against revising the language of the setup completion button, but if we do, we should update it for GTM too, which has its own for some reason. See https://google.github.io/site-kit-wp/storybook/develop/?path=/story/tag-manager-module-setup--set-up-a-new-container

We should align on the exact wording with @marrrmarrr before proceeding though.

I'm also not entirely clear if it should be "complete set up" or "complete setup" (we have "redo setup" so that may be the correct form).

[mxbclang]

@aaemnnosttv I meant to chime in about that! "Setup" is the noun and "set up" is the verb, so it should be "setup" here. :)

[jimmymadon]

@marrrmarrr We discussed this issue on our last Team Review call. The idea here was to update the CTAs so that we can convey the fact that the screen the user is on is the "final step" in setting up a module (so as to encourage them to fill up the form). "Complete setup" is a good option here. Other longer options which could be possible:

• "Save & finish"
• "Save & complete setup"
• "Configure & complete setup"

What should we go for in the end?

[marrrmarrr]

@jimmymadon I think "complete setup" is a good option here.

[jimmymadon]

I think the AC and IB look good here based on the reviews and discussions above. But I'll let an AC / IB reviewer give their ✅ of approval before moving this to EB.

[eugene-manuilov]

Thanks, @jimmymadon. AC and IB 🌶️

[mohitwp]

QA Update ✅

• Tested on dev environment.
• Verified that now the wording of the button which finishes a successful setup for all of our modules, ie. Google Analytics, AdSense and Tag Manager updated to say "Complete setup" (instead of "Configure " or "Confirm & Continue").