google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

Revise Submit button wording for the final step in saving module settings #5401

Closed wpdarren closed 8 months ago

wpdarren commented 2 years ago

Bug Description

This was identified during the bug bash by James, as a post launch issue for AdSense Setup Improvement. If a user has an approved AdSense account and their site is also approved (ready) they'll be prompted to "Configure AdSense", before the service is connected. As there isn't any configuration applicable consider changing the wording to "Connect AdSense" or "Complete setup".

Recording of experience here.

Asana ticket can be found here https://app.asana.com/0/1202175292782289/1202322830239183/f


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

ivonac4 commented 10 months ago

@marrrmarrr Are you still planning to review this soon? If not, can you please unassign yourself so someone else can pick up? Thank you!

ivonac4 commented 10 months ago

@marrrmarrr Sorry, I misread the comments here, I realize now it is on you to review it. Do you mind taking a look at it when you have time? Thanks!

eugene-manuilov commented 9 months ago
  • Update the wording of the button which finishes a successful setup for both, Google Analytics and AdSense to say "Complete set up" (instead of "Configure ").

@aaemnnosttv, I am not sure that we should change the button label for the Analytics setup form here. The intention of this ticket is to adjust the language for the AdSense setup process to have a more accurate button label when the actual configuration of the AdSense module is already completed and we need to do the final step to connect the module. In the Analytics module the setup flow is different and has only one step to save configuration and having the "Configure Analytics" label makes sense to me. What do you think?

jimmymadon commented 9 months ago

@eugene-manuilov My main reason to use "Complete set up" is that if the "next step" is going to be a "Success Banner", then saying "Configure XX" makes it look like there are more steps involved and that some users might not want to continue. In all "wizards", the last step is always clear with an action button like "Finish" that conveys that there are no more steps involved.

jamesozzie commented 9 months ago

@eugene-manuilov @aaemnnosttv The difference with the AdSense module "Configure..." label compared to the Analytics module, is that you are configuring Analytics. There are no configurations applicable when setting up AdSense. See below images:

AdSense module setup - No configurations applicable image

Analytics module setup - Configurations can be applied on this screen image

Considering there are AdSense configurations (screenshot), maybe we could allow configuration on this screen, at least the option to enable/disable ads for logged in users.

Maybe we could hold off on this issue and allow users to select AdSense configurations on this initial setup screen? I'm happy to open an issue for this if so.

jimmymadon commented 9 months ago

@jamesozzie Even though we are "configuring" some settings on the screen we are on, the CTA could convey clearly the message that there is no "further" configuration to be done and this is a "Save and Finish" situation. c.c. @sigal-teller

aaemnnosttv commented 9 months ago

I am not sure that we should change the button label for the Analytics setup form here

@eugene-manuilov I didn't include Analytics in the original AC :)

@jimmymadon if we're going to go beyond only AdSense here, the name of the issue should probably be updated to reflect that. I'm not against revising the language of the setup completion button, but if we do, we should update it for GTM too, which has its own for some reason. See https://google.github.io/site-kit-wp/storybook/develop/?path=/story/tag-manager-module-setup--set-up-a-new-container

We should align on the exact wording with @marrrmarrr before proceeding though.

I'm also not entirely clear if it should be "complete set up" or "complete setup" (we have "redo setup" so that may be the correct form).

mxbclang commented 9 months ago

@aaemnnosttv I meant to chime in about that! "Setup" is the noun and "set up" is the verb, so it should be "setup" here. :)

jimmymadon commented 9 months ago

@marrrmarrr We discussed this issue on our last Team Review call. The idea here was to update the CTAs so that we can convey the fact that the screen the user is on is the "final step" in setting up a module (so as to encourage them to fill up the form). "Complete setup" is a good option here. Other longer options which could be possible:

What should we go for in the end?

marrrmarrr commented 9 months ago

@jimmymadon I think "complete setup" is a good option here.

jimmymadon commented 9 months ago

I think the AC and IB look good here based on the reviews and discussions above. But I'll let an AC / IB reviewer give their ✅ of approval before moving this to EB.

eugene-manuilov commented 9 months ago

Thanks, @jimmymadon. AC and IB 🌶️

mohitwp commented 8 months ago

QA Update ✅

![image](https://github.com/google/site-kit-wp/assets/94359491/035dd728-8800-467a-8fdd-100004d9e484) ![image](https://github.com/google/site-kit-wp/assets/94359491/10253d6a-4b95-4aa9-ade6-c7367543a3c0) ![image](https://github.com/google/site-kit-wp/assets/94359491/4a453cdb-49d2-478a-8b4f-b5bfe427c5f3)