Closed aaemnnosttv closed 1 year ago
Updated the copy here.
Using
assets/js/components/setup/ModuleSetup.js
,
- Render
OptimizeSunsetNotice
ifmoduleSlug
isoptimize
.
@asvinb, we should render it in assets/js/modules/optimize/components/setup/SetupMain.js
, shouldn't we?
You're right @eugene-manuilov . IB updated 😁
IB ✔️
Planning to schedule for Sprint 99, ending April 21.
Verified:
Connect More Services
tab. Completed testing on desktop and mobile viewports.
Note: I did observe the warnings were full-width where they were previously limited. #7140 will fix this.
LGTM 👍
Feature Description
In addition to the banner notification in #6467, we will also add a number of contextual notices to inform users about the Optimize sunset.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
An inline warning should be added to the Optimize module's tile on the Connect More Services tab, similar to the warning shown when Analytics is not active (reference)
An inline warning should be added to the top of the Optimize module's setup, settings view, and settings edit components (example)
Learn more URL (all instances):
https://support.google.com/optimize/answer/12979939
These warnings are to be static, and non-dismissible
Implementation Brief
assets/js/components/settings/SetupModule.js
,ModuleSettingsWarning
component, render the text from the first bullet point from the AC ifslug
isoptimize
.assets/js/components/notifications/ModuleSettingsWarning.js
including the icon.assets/js/modules/optimize/components/common/OptimizeSunsetNotice.js
which exports theOptimizeSunsetNotice
functional component.SettingsNotice
component with the type set toTYPE_WARNING
.assets/js/modules/optimize/components/setup/SetupMain.js
,assets/js/modules/optimize/components/settings/SettingsView.js
andassets/js/modules/optimize/components/settings/SettingsEdit.js
, renderOptimizeSunsetNotice
in first position before any other text.core/site
datastore via thegetGoogleSupportURL
selector.Test Coverage
QA Brief
Changelog entry