google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 290 forks source link

Update the source links in GA4 Reporting widgets to use the correct GA4 report URLs. #6639

Closed techanvil closed 1 year ago

techanvil commented 1 year ago

Feature Description

As discussed on Slack, we need to determine and use the correct URLs for the source links for the GA4 Reporting widgets.

In order not to block development, we can initially use the UA version of the URLs, and then update them once we have specced the GA4 URLs.

This outcome of this issue should be to have updated the various GA4 Reporting widgets with the correct source link URLs. Further detail can be added once the URLs are known, this is currently with @marrrmarrr to spec them out.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

See https://docs.google.com/document/d/17RKIrdm5PBK8j6rP0GV_2QlztSLXqYQX8ikz3kQmrAo/edit?pli=1&resourcekey=0-njOU7bn1dhvi5Yp2jeX5zw#bookmark=id.9e5lpgtwjov3 for metrics to use to replace these links.

Implementation Brief

Test Coverage

QA Brief

Changelog entry

marrrmarrr commented 1 year ago

@techanvil I've added a section in the PRD with a list of links to be updated. Let me know if this info is enough, or we need more context.

techanvil commented 1 year ago

Thanks @marrrmarrr - I've left a few related questions on the PRD.

techanvil commented 1 year ago

The definition for this issue can now be completed, referring to the the new section in the PRD.

tofumatt commented 1 year ago

The example links are behind a Google corporate link I can't access, but I think the references are enough; I've gone through and listed example links for all the new metrics in GA4 we can use.

techanvil commented 1 year ago

Hey @tofumatt, nice work here. Just letting you know, I spotted a reference to page_url which was left in the PRD by accident and should in fact be unifiedPagePathScreen, so I have updated the AC accordingly (and left a suggestion to update the PRD).

techanvil commented 1 year ago

Hey @kuasha420, the IB is looking good. I have a few comments on it, please take a look.

kuasha420 commented 1 year ago

Thanks @techanvil for the feedback. I have updated the IB to account for all three points you raised. I didn't realize that there was JSON encoded object hiding in the query params! I thought there was only url encoding so didn't feel the need to elaborate further. :disappointed: Thanks for catching it.

techanvil commented 1 year ago

Thanks, @kuasha420!

IB :white_check_mark:

mohitwp commented 1 year ago

QA Update ⚠️

@techanvil Below is the AC for All traffic channels and Locations All Traffic Widget:

Both above mentioned URL contain - 'dashboard' whereas actual URL have 'explorer' at the place of dashboard. Example URL (https://analytics.google.com/analytics/web/?pli=1#/p285794360/reports/explorer?params=_r..nav%3Dmaui%26_u.date00%3D20230308%26_u.date01%3D20230404%26_u.date10%3D20230208%26_u.date11%3D20230307%26_r.explorerCard..selmet%3D%5B%22activeUsers%22%5D%26_r.explorerCard..seldim%3D%5B%22country%22%5D&r=user-demographics-detail&collectionId=user)

URL for devices tab contain explorer in AC and it is same as actual URL. Although, the URL destination is as per AC but want to flag this difference. Is URL mentioned under AC is correct ? and if it correct then should we require changes here in actual URL ?

techanvil commented 1 year ago

Hi @mohitwp, thanks for flagging this.

The URLs you've mentioned in the AC are not quite correct. For some reason the URL seems to have been pasted from the Overview section of the relevant report, rather than the details section we actually want to navigate to.

Reports > Life cycle > Acquisition > Overview

image

Reports > Life cycle > Acquisition > Traffic acquisition (the correct report)

image

Reports > Demographics > Overview

image

Reports > Demographics > Demographic details: Country (the correct report)

image

So, in a nutshell the AC is a little off, and the links do navigate to the correct report URLs.

mohitwp commented 1 year ago

QA Update ✅

**Channel -** ![image](https://user-images.githubusercontent.com/94359491/230623497-df13a529-b653-4d0b-894c-a0f0a2ca4cf7.png) **Locations -** ![image](https://user-images.githubusercontent.com/94359491/230623680-1768fba5-3e91-4cb8-a7c0-d5a7e3a9498a.png) **Devices -** ![image](https://user-images.githubusercontent.com/94359491/230633002-7e238825-ee56-416b-8c54-e856b0c993e4.png) **Search traffic widget - Both 'Unique visitors from search' and 'Conversions' tab navigating to same URL.** ![image](https://user-images.githubusercontent.com/94359491/230633367-98ec39c8-ad34-4f69-8d15-8e1ab84b1841.png) **Top content widget -** ![image](https://user-images.githubusercontent.com/94359491/230634696-465662e9-31b7-4375-b301-524fc246a9b1.png) **Entity page -All traffic widget** ![image](https://user-images.githubusercontent.com/94359491/230635063-ef4c3906-6570-4786-98ea-91e581bfefad.png) **Entity Dashboard - Overall page metrics** ![image](https://user-images.githubusercontent.com/94359491/230635453-3f01bb58-b1f3-4e57-a721-bf100daf23f0.png)