Address inconsistencies with punctuation in copy

[techanvil]

Feature Description

There is a bit of inconsistency with the way punctuation is applied in the plugin. For a specific example, see the Analytics settings view:

We should audit the plugin for any such inconsistencies, and fix them.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• All strings within the plugin should be reviewed for punctuation to follow our style guide as mentioned below:

"Skip periods and unnecessary punctuation

To help readers scan text, avoid using periods and other unnecessary punctuation.

Avoid using periods to end single sentences, particularly in: - Labels - Tooltip text - Bulleted lists - Dialog body text - Hyperlinked text

Use periods on: - Multiple sentences - Long or complex sentences, if it suits the context - Any sentence followed by a link"

Implementation Brief

• At the time of writing, some locations have period on the end of the sentence that should be removed:
  • When editing Tag Manager settings, for code placement description
  • On connect more services tab, when all modules are connected, for the description We’re working on adding new services to Site Kit by Google all the time, so please check back in the future.
• Screenshot attached in AC is no longer relevant, UA is not present any more, and GA4 placement text doesn't have a dot at the end of label any more.
• Following the style guide added in AC, check the overall plugin components text content if there is any other place that needs edit.

Test Coverage

• No test update is needed
• Update any failing VRT reference images

QA Brief

• Ensure the periods are used consistently across the plugin UI. Specially - Site Kit Setup screen, settings screen, module setup, settings view and settings edit screen, various banner notifications, SK Widgets, WP Dashboard Widgets, Admin Bar widgets, AdSense Setup CTA, Ad Blocking Recovery Setup CTA and flow, User Input and Key Metrics setup and edit flows, Sharing settings.

Changelog entry

• Address inconsistencies with punctuation in copy throughout the plugin.

[jimmymadon]

@marrrmarrr What is Site Kit's policy on punctuation for statements/sentences? It feels like all full sentences (barring a few exceptions as mentioned in the Issue description) within the plugin do not end with a full-stop, unless there are multiple sentences combined together where a full-stop is obviously needed. Should this be the case throughout our UI?

c.c. @aaemnnosttv @sigal-teller

[marrrmarrr]

@jimmymadon according to the style guide, single-sentence phrases like the ones in the screenshot above should have no full stop. If there is more than one sentence, then it's necessary to separate them with full stops.

Here is the full guidance for reference: "Skip periods and unnecessary punctuation

To help readers scan text, avoid using periods and other unnecessary punctuation.

Avoid using periods to end single sentences, particularly in: - Labels - Tooltip text - Bulleted lists - Dialog body text - Hyperlinked text

Use periods on: - Multiple sentences - Long or complex sentences, if it suits the context - Any sentence followed by a link"

[techanvil]

AC :white_check_mark:

[tofumatt]

IB ✅

[wpdarren]

QA Update: ⚠️

@kuasha420 Other than the first issue highlighted, I am not 100% sure about the others.

Would appreciate your opinion since these aren't multiple sentences.

1. We have a period in the Ad Blocking Recovery screen.

2. For the user input survey questions, we have a description. Should the description have a period when there is a comma within the text?

3. The same question above. I noticed a period in a few other places. Maybe if there's a comma, then it should have a period.

4. I found this period on the Dashboard Sharing view-only panel.

[kuasha420]

@wpdarren Thank you for the detailed testing and observation. As mentioned by @bethanylang on Slack, the the periods removed from the lines with commas are fine. I've opened an additional PR to remove the other periods you've found. Cheers.

[techanvil]

Back to you for another pass, @wpdarren.

[wpdarren]

QA Update: ❌

@kuasha420 Just two observations, and I think we are done.

1. The user input descriptions still have a period. I think we said that they shouldn't. Am I correct?

2. Apologies, I didn't notice this in my first round of testing.

The AdSense 'ready' status screen needs the period removing.

[wpdarren]

QA Update: ✅

Verified:

• Periods are used consistently across the plugin UI.
• Especially - Site Kit Setup screen, settings screen, module setup, settings view and settings edit screen, various banner notifications, SK Widgets, WP Dashboard Widgets, Admin Bar widgets, AdSense Setup CTA, Ad Blocking Recovery Setup CTA, and flow, User Input and Key Metrics setup and edit flows, Sharing settings.

Screenshots