Enhance AdSense Existing Tag detection to detect AdSense Auto Ads snippet

[kuasha420]

Feature Description

Currently AdSense existing tag detection only detects old style AdSense tags. But it does not detect new Auto Ad Snippets. We should enhance the detection to detect both snippets as existing AdSense tag.

Old tag example:

<script data-ad-client="ca-pub-xxxxxx" async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script>

Auto ads tag example:

<script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-xxxxxx"
     crossorigin="anonymous"></script>

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The existing tag selectors (getExistingTag and hasExistingTag) of AdSense module should be updated to detect both the old style and auto ad AdSense snippets.

Implementation Brief

In assets/js/modules/adsense/util/tag-matchers.js:

• Modify the tag matcher array to include one of the following regex patterns that detect the new auto ad snippet:
  • A general pattern that matches the client ID:

    /<(?:script|amp-auto-ads)[^>]*src="[^"]*\?client=([^"]+)"[^>]*>/,

  • A more specific pattern that looks for the ca-pub prefix:

    /<(?:script|amp-auto-ads)[^>]*src="[^"]*\?client=(ca-pub-[^"]+)"[^>]*>/

• Both the patterns work in my testing.

Test Coverage

• In assets/js/util/test/extractExistingTag.js, add a new test case to detect the new Auto Ad Snippet script tag similar to other test cases.

QA Brief

In order to test this functionality, a custom AdSense script of the new version format must be added to the page by a means other than site kit. This can be done via the active themes functions.php file, or via a custom mu-plugin.

• Edit the active themes functions.php file (or create one if not present), OR
• Create a new mu-plugin at [...]/wp-content/mu-plugins/00-adsense-testing.php
  • You can create the mu-plugins folder if it does not yet exist
• Whether using the functions.php file or mu-plugin method, add the following snippet of code to either of the above locations:

add_action( 'wp_head', 'sk_add_adsense', 0, 15 );

function sk_add_adsense() {
?>
<!-- Added by QA (#7259) -->
<script async src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js?client=ca-pub-3467161889682403" crossorigin="anonymous"></script>
<?php
}

• IMPORTANT: Be sure to replace the pub ID in the example above (3467161889682403) with the pub ID of the AdSense account attached to your test environment.
• In wp-admin, navigate to Google Site Kit > Settings > AdSense
• Click the Edit CTA link for said module
• Validate that the correct "tag already present" message shows, as per the below screenshot:

• Remove the mu-plugin or the code from the functions.php file of said theme and validate that the "tag already present" message disappears.

Changelog entry

• Enhance AdSense existing tag detection to detect AdSense Auto Ads snippets.

[jamesozzie]

I can confirm the same. Site Kit is placing the plugin inserted AdSense snippet despite an existing AdSense snippet already manually placed. Recording.

[tofumatt]

ACs are good 👍🏻

[eugene-manuilov]

IB ✔️

[wpdarren]

QA Update: ⚠️

@10upsimon thanks for the helpful QAB instructions! I have an observation. I ran some additional testing with setting up AdSense with the mu-lugin activated. I saw the tag already present message, but when I enable the toggle another message appears warning of a potential conflict. See screenshot below.

When I do the same in Analytics settings, the text doesn't change. Should it?

This is what I see when the toggle is disabled.

This is the text that appears when the toggle is enabled.

[wpdarren]

QA Update: ✅

Verified:

• The correct tag already present message shows when my mu-plugin is installed.
• When my mu-plugin is removed, the tag already present message does not appear.
• Also tested this when setting up AdSense with the mu-plugin installed just to make sure the message appears there too.