Remove [Not Set] from Key Metric tiles

[wpdarren]

Bug Description

While completing testing on Key Metric Widget, I noticed that the Top cities driving traffic metric tile has a [not set] entry appearing. I feel we need to filter these out from all metric tiles as it's not helpful.

We did remove it from the custom dimension tiles.

Private Zenhub Image

Steps to reproduce

1. Setup Site Kit and connect the Oi.ie Analytics account.
2. Select the Top cities driving traffic metric tile from the selection panel.
3. Observe that the [not set] is appearing in the top 3 cities.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Filter out any (not set) rows in all key metrics tiles.
  • This essentially means any key metric, where the dimension could potentially be (not set) should have a dimension filter to filter out such rows. Currently, this affects the Most popular countries and Most popular cities tiles (in addition to the popular products, popular authors and popular categories tiles where not set is already being filtered out).

Implementation Brief

• [ ] In assets/js/modules/analytics-4/components/widgets/TopCountriesWidget.js and assets/js/modules/analytics-4/components/widgets/TopCitiesWidget.js:
  • [ ] Follow the pattern in assets/js/modules/analytics-4/components/widgets/PopularAuthorsWidget.js.
  • [ ] Add the exact same dimensionFilters as the above file for country and city dimensions appropriately.

Test Coverage

• No new tests required.

QA Brief

Changelog entry

[jimmymadon]

This issue is related to #7737. In that issue, we identified the cause of "(not set)" records to be the fact that we do not track custom dimensions like categories and authors for all post types. This does not explain "not set" as a value for cities which might simply be untracked at times. Based on my observation, the number of not set records for cities is much larger than countries on all of my live sites with real data. So there could be an issue where the city isn't always being sent with all events being tracked.

Anyway, this means we will have to make a decision to filter out 'not set' from all our key metric tile reports where the possibility of the dimension value could be not set. I suppose this will require approval from a merge reviewer (tagging @aaemnnosttv, @techanvil and @eugene-manuilov as they were involved in the related issue) and also @andreylipattsev.

[eugene-manuilov]

IB :heavy_check_mark: