google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.22k stars 278 forks source link

Building VRT docker image fails when `ROOT_DIR` contains a space #7898

Closed derweili closed 1 month ago

derweili commented 9 months ago

Bug Description

When using a local environment like Local, WordPress lives in a Local Sites folder that has a space in it's name.

This space in the path name causes bin/backstop to fail building the docker image with following error:

ERROR: "docker buildx build" requires exactly 1 argument.
See 'docker buildx build --help'.

Steps to reproduce

  1. Clone the Site Kit repo in a folder with a space in its path and install the dependencies.
  2. Verify the googlesitekit/vrt:* image does not exist on your machine.
  3. Run test:visualtest
  4. See the above error

Additional Context


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

tofumatt commented 1 month ago

IB ✅

10upsimon commented 1 month ago

ENG:QA Update - Pass ✅

image