Release 1.116.0 - Githubissues

google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.

https://sitekit.withgoogle.com

Apache License 2.0

1.23k stars 284 forks source link

Release 1.116.0 #7953

Closed aaemnnosttv closed 9 months ago

aaemnnosttv commented 9 months ago

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Release is prepared, tested, and deployed to wordpress.org.

Implementation Brief

QA Brief

Changelog entry

wpdarren commented 9 months ago

QA Update: ✅

I went through our usual QA checks:

Tested on a site in gathering and zero data state.
Tested on a site with live data.
Tested Dashboard sharing
Tested AdBlocking Recovery
Tested Enhanced Measurement
Tested User Input and KMW widget

Note: there are several UI issues related to 7968 and 7542. Mohit and I have documented them on Slack, so when the two tickets are merged, we can do a full check of all icons/SVGs.

zutigrm commented 9 months ago

Release QA: ✅

Performed a general smoke test of the plugin
Did general testing through the changelog
Tested changes I have been involved with
Checked on different device sizes

Some observations:

Change metrics button focus/and default state has alignment issue, but is part of reported/known issue
I got notification timeout console error, which is also a known issue.
I also noticed that in shared dashboard, custom dimensions metrics all show in gathering state, not sure if this is expected behaviour?

tofumatt commented 9 months ago

QA ✅

Tested existing site upgrade.
Tested new site set up/gathering data.
Tested uninstall/reinstall on existing site.
Checked Dashboard Sharing behaviour and Entity Dashboard behaviour on new/old site.

Aside from alignment issues that are being fixed in #7968, all looks good to me. 👍🏻

techanvil commented 9 months ago

QA :warning:

:white_check_mark: Performed a general smoke test of the plugin. :warning: Verified/smoke tested the changes I’ve been involved with. :white_check_mark: Performed some ad-hoc testing.

While testing #6584 I noticed a minor glitch in the loading state for the AdSense setup screen. The screen initially displays with a progress bar, but then briefly shows the spinner button with the spinner active. All of the loading should have taken place by the time the button is shown.

https://github.com/google/site-kit-wp/assets/18395600/fda6e88a-b0b3-4ed1-8ed9-1f0f6d911c4c

This is a minor defect that we could potentially fix in a followup issue.