Closed tofumatt closed 8 months ago
Hey @tofumatt, regarding the second IB point, I think it would be worth being more specific about what other content/logic we should include, as it looks like some of this should be covered by https://github.com/google/site-kit-wp/issues/8059.
It's also worth noting that the AC for this issue seems to be partially duplicated in #8059 - cc @hussain-t who's working on the IB for that issue which can probably refer in part to this one.
Thanks @techanvil. I referenced the lines in the IB, but I've added some notes to the IB here.
I've also referenced this IB in #8059 as well 👍🏻
Thanks @tofumatt, looks good. Just one thing, the GA4 version of the widget already includes a copy of the Footer
component so it looks like we can remove that sub-point.
@tofumatt Just noting that this is one that we can get started on at any time, so would be great to get these IB updates taken care of so we can start on it ASAP. Thanks!
Thanks @tofumatt, IB :white_check_mark:
Hi folks!
I've set this issue as blocked by #8048 as the new setting adSenseLinked
(see https://github.com/google/site-kit-wp/issues/8047#issuecomment-1903498239) is not yet available in the analytics-4
datastore.
Thanks!
CC: @tofumatt @techanvil @bethanylang @ivonac4
@tofumatt I can see you removed this issue from the AdSense GA4 Integration epic. Was that on purpose? If so, can you loop me in please? Thankss
@ivonac4 I'm guessing that was an error, as it happened at the same time this was removed from the release. Adding it back!
Okay, thanks!
(Indeed, that looks to be a Zenhub bug! 😅 Thanks @ivonac4 for catching it and @bethanylang for restoring it!)
Issue : If AdSense module is shared then On View only dashboard error is showing.
@zutigrm
Issue : As reported in slack earlier and in #6248 . I used oi.ie site for testing. Analytics and AdSense are already linked for this site but still on main dashboard under Monetization section prompt to link AdSense and Analytics is showing.
The real adSenseLinked
setting value is not pulled yet, so only default value is present, which is false
, so it will always show connect section. The value will be fetched in other issue, see this comment
cc: @mohitwp @tofumatt
Adding #8049 as a blocker, and removing this issue from this release as we can't really properly test it (or release this widget) until the data can also be fetched from the Analytics API.
I'll create a follow-up issue to not render this for now.
ga4AdSenseIntegration
feature flag is active then and only promot is showing.ga4AdSenseIntegration
feature flag is not active then promot is not showing.Note : Putting note here to test again when #8049 get merge.
Feature Description
We'll want a version of the "Top Earning Pages Widget" (#6248) that shows a CTA to link the user's AdSense and Analytics accounts when they are not linked (or we don't detect that they are linked).
See: https://docs.google.com/document/d/1-JenwPTAkw0eTkmESzjTOfgphs9qpRYH0h3xk_s3a4o/edit#heading=h.ykym38w7pngs
NOTE: This issue must be deployed in the same release as #6248 and #8051.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
DashboardTopEarningPagesWidgetGA4
component should return theAdSenseLinkCTA
component when Analytics and AdSense are not connected (eg. when theadsenseLinked
Analytics setting from #8048 isfalse
), similar to how the existingDashboardTopEarningPagesWidget
component behaves.DashboardTopEarningPagesWidget
component, this should only happen on the "regular" dashboard, not the view-only dashboard (eg. shared dashboard), because users in view-only mode likely won't have permissions to link these accounts.Implementation Brief
DashboardTopEarningPagesWidgetGA4
to check forselect( MODULES_ANALYTICS_4 ).getAdsenseLinked()
and whether the context is view-only dashboard. If the context is not view-only andadsenseLinked
isfalse
, output<AdSenseLinkCTA />
, the same as https://github.com/google/site-kit-wp/blob/8612fe95e03b6029aab6cd32c9df6afd1d860225/assets/js/modules/adsense/components/dashboard/DashboardTopEarningPagesWidget.js#L166-L172isAdblockerActive
logic that returns an Ad Blocker warning.! isAdSenseLinked && viewOnlyDashboard
logic that does not output the widget when AdSense is not linked and the user is on the view-only dashboard.Test Coverage
QA Brief
ga4AdSenseIntegration
feature flagWhen the
ga4AdSenseIntegration
feature flag is disabled, this KMW tile should not appear.Changelog entry