Closed tofumatt closed 7 months ago
IB ✔️
The PR for this issue looks good and is approved. However, I'm keeping this stalled in MR as I can't merge it yet. According to the issue description, this should go out with the same release as #6248 and #8050.
QA Update :
Blocked due to issue mentioned under #6248 and #8050 .
cc @wpdarren @bethanylang
QA Update
googlesitekit.data.dispatch('modules/analytics-4').setAdSenseLinked(true)
not changes infor under site heath info.--AdSense Linked --AdSense Linked Last Synced At
Feature Description
The status of AdSense/Analytics linked accounts (eg. the value of the Analytics setting
adsenseLinked
, added in #8047) should be output in the Site Health information for Site Kit.NOTE: This issue must be deployed in the same release as #6248 and #8050.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
adsenseLinked
setting should be output in the Site Health settings when both Analytics 4 and AdSense modules are connected.adSenseLinkedLastSyncedAt
value should be output.adSenseLinkedLastSyncedAt
setting is empty, output "Never synced"adSenseLinkedLastSyncedAt
is not empty, output the time it was last synced, either as a UNIX timestamp or UTC value.Implementation Brief
Google\Site_Kit\Modules\Analytics_4::get_debug_fields
:AdSense Linked
field to the debug fields array. For value check foradsenseLinked
settings and render the content from AC. Fordebug
key, wrap the setting withredact_debug_value
methodAdSense Linked Last Synced At
field to the debug fields array, like previously and output the content described in ACTest Coverage
tests/phpunit/integration/Modules/Analytics_4Test.php
, add 2 newly added keys to the list intest_get_datapoints__news_key_metrics
QA Brief
Changelog entry
adSenseLinked
to Site Health information.