Closed tofumatt closed 5 months ago
(Moving to stalled because this component doesn't exist yet.)
@marrrmarrr Do you have a Figma design/screenshot/reference for the component that the view_notification
+ {viewContext}_top-earning-pages-success-notification
event corresponds to from the Analytics events document? I wasn't able to find one, but if there is one I can create an issue to make that component as well.
@marrrmarrr @ivonac4 We now have issues filed for this component, so I've marked this as blocked by those two issues ππ»
@tofumatt could you please update IB to have actual implementation brief, because right now it looks like an exact copy of AC.
@eugene-manuilov Sure thing, I had written it before the component was totally implemented π
EDIT: Oh, looks like the component is still in execution, I'll add more to the IB once the component is ready.
Updated the IB to reference the actual components, though since the issue should be completed this sprint and that issue is still in execution/code review I've referenced the PR π
Should be good though π
Thanks, @tofumatt. IB βοΈ
Verified that all events are getting trigger as per AC.
1> trackEvent( {viewContext}_top-earning-pages-widget
, 'view_overlay_CTA' ) when the notification is rendered and shown to the user
2> trackEvent( {viewContext}_top-earning-pages-widget
, 'confirm_overlay_CTA' ) when the user clicks the "Show me"/primary CTA
3> trackEvent( {viewContext}_top-earning-pages-widget
, 'dismiss_overlay_CTA' ) when the user clicks the "Maybe later"/secondary CTA
Feature Description
GA events (eg.
trackEvent
calls) should be added to the new "Top Earnings Pages" overlay (#8237) that appears on the Site Kit dashboard when the user connects their accounts and has data available. There should be one when a user views the overlay, one when they click the "Show me" link in the overlay, and another when the user dismisses the overlay.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
trackEvent
calls should be made:trackEvent( `{viewContext}_top-earning-pages-widget`, 'view_overlay_CTA' )
when the notification is rendered and shown to the usertrackEvent( `{viewContext}_top-earning-pages-widget`, 'confirm_overlay_CTA' )
when the user clicks the "Show me"/primary CTAtrackEvent( `{viewContext}_top-earning-pages-widget`, 'dismiss_overlay_CTA' )
when the user clicks the "Maybe later"/secondary CTACTA widget screenshot:
Implementation Brief
trackEvent( `{viewContext}_top-earning-pages-widget`, 'view_overlay_CTA' )
whenshouldShowNotification
istrue
inAnalyticsAndAdSenseAccountsDetectedAsLinkedOverlayNotification
onClick
handler for the "Show me" button to also calltrackEvent( `{viewContext}_top-earning-pages-widget`, 'confirm_overlay_CTA' )
trackEvent( `{viewContext}_top-earning-pages-widget`, 'dismiss_overlay_CTA' )
to the "dismiss" handler at https://github.com/google/site-kit-wp/pull/8399/files#diff-dde7a931a349093a2dc4b056807b51019b4555ec16f3dbf4a8793a82c1c66ff3R167-R173Test Coverage
QA Brief
ga4AdSenseIntegration
feature flagoi.ie
should) and view the notificationmainDashboard_top-earning-pages-widget
,view_overlay_CTA
event should be sentmainDashboard_top-earning-pages-widget
,dismiss_overlay_CTA
event should be sentmainDashboard_top-earning-pages-widget
,confirm_overlay_CTA
event should be sentChangelog entry