google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.23k stars 284 forks source link

Add GA events for "Top Earnings Pages" overlay CTA #8213

Closed tofumatt closed 5 months ago

tofumatt commented 7 months ago

Feature Description

GA events (eg. trackEvent calls) should be added to the new "Top Earnings Pages" overlay (#8237) that appears on the Site Kit dashboard when the user connects their accounts and has data available. There should be one when a user views the overlay, one when they click the "Show me" link in the overlay, and another when the user dismisses the overlay.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

CTA widget screenshot:

Screenshot 2024-02-19 at 23 35 03

Implementation Brief

Test Coverage

QA Brief

Changelog entry

tofumatt commented 7 months ago

(Moving to stalled because this component doesn't exist yet.)

tofumatt commented 7 months ago

@marrrmarrr Do you have a Figma design/screenshot/reference for the component that the view_notification + {viewContext}_top-earning-pages-success-notification event corresponds to from the Analytics events document? I wasn't able to find one, but if there is one I can create an issue to make that component as well.

tofumatt commented 7 months ago

@marrrmarrr @ivonac4 We now have issues filed for this component, so I've marked this as blocked by those two issues πŸ‘πŸ»

eugene-manuilov commented 6 months ago

@tofumatt could you please update IB to have actual implementation brief, because right now it looks like an exact copy of AC.

tofumatt commented 6 months ago

@eugene-manuilov Sure thing, I had written it before the component was totally implemented πŸ˜…

EDIT: Oh, looks like the component is still in execution, I'll add more to the IB once the component is ready.

tofumatt commented 6 months ago

Updated the IB to reference the actual components, though since the issue should be completed this sprint and that issue is still in execution/code review I've referenced the PR πŸ˜„

Should be good though πŸ˜…

eugene-manuilov commented 6 months ago

Thanks, @tofumatt. IB βœ”οΈ

mohitwp commented 5 months ago

QA Update βœ…

![image](https://github.com/google/site-kit-wp/assets/94359491/476c260f-ef50-4321-90da-25edad08c0ee)

2> trackEvent( {viewContext}_top-earning-pages-widget, 'confirm_overlay_CTA' ) when the user clicks the "Show me"/primary CTA

![image](https://github.com/google/site-kit-wp/assets/94359491/d35e184c-c2da-4e0a-8a2a-65d9007fc455) https://github.com/google/site-kit-wp/assets/94359491/1f7dae03-1fdd-4d2f-8463-d33f4d18153d

3> trackEvent( {viewContext}_top-earning-pages-widget, 'dismiss_overlay_CTA' ) when the user clicks the "Maybe later"/secondary CTA

![image](https://github.com/google/site-kit-wp/assets/94359491/9403cfcd-7746-438f-92ea-7c8fa900cbf9) https://github.com/google/site-kit-wp/assets/94359491/4949800b-cee7-438e-b5d3-0d9f0bf09227