google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

Release 1.121.0 #8244

Closed aaemnnosttv closed 8 months ago

aaemnnosttv commented 9 months ago

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

QA Brief

Changelog entry

tofumatt commented 8 months ago

QA ✅

All looks good to me 👍🏻

wpdarren commented 8 months ago

QA Update: ⚠️

I think I have found a regression that could be related to SAM changes in this release. Within Analytics settings, I have disabled the ‘Exclude Analytics’ in Analytics settings and went to the source code to check that the opt-out tags were removed, but they’re still appearing there. I switched to the latest release, and the tags are not appearing as expected. I have done a screencast to show you what I mean. You might have to skip parts of the video; my internet is a bit slow tonight.

Left a note on Slack for @jimmymadon to investigate.

https://github.com/google/site-kit-wp/assets/73545194/572592b9-647d-4c5a-a13c-f1336b97f7b6

wpdarren commented 8 months ago

QA Update: ✅

I found a regression bug that @jimmymadon has recreated and found the cause. He will create a ticket; we must include it in this release. Slack conversation can be found here.

I went through our usual QA checks:

Ran additional checks for GA4, GTM, and AdSense due to epics in engineering.

mohitwp commented 8 months ago

QA Update ✅

kuasha420 commented 8 months ago

Release QA: :heavy_check_mark:

LGTM.

zutigrm commented 8 months ago

QA ✅

Looks good. Although I have a question:

Screenshot 2024-02-26 at 10 16 05

On single page view - these have been sitting there for a while, should we still continue showing the new badge?

wpdarren commented 8 months ago

@zutigrm we have a ticket for that in Github, #8203 👍