Closed tofumatt closed 5 months ago
IB ✔️
(I realised today this is actually due for the next sprint, but leaving it assigned to me as I've nearly completed the issue already 😅)
@tofumatt Can you add a QAB here - as you have more context about the whole thing and may want to get some specific stuff QA'd. Feel free to unassign yourself afterwards. Cheers.
@kuasha420 Oh my, I just totally forgot, yes! Thanks 😅
Verified:
Feature Description
We should remove the
ga4AdSenseIntegration
feature flag to deploy that feature fully to users in the1.124.0
release.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
ga4AdSenseIntegration
feature flag should be removed from the plugin.ga4AdSenseIntegration
should act like it's always on.ga4AdSenseIntegration
should continue to pass.ga4AdSenseIntegration
being disabled can be removed.Implementation Brief
ga4AdSenseIntegration
from thefeature-flags.json
file.ga4AdSenseIntegration
string. Examine each instance where it is used.ga4AdSenseIntegration
feature flag, adjust the code to ensure these are rendered unconditionally.isFeatureEnabled( 'ga4AdSenseIntegration' )
utility function is used.useFeature
hook is utilized withga4AdSenseIntegration
as an argument.Feature_Flags::enabled( 'ga4AdSenseIntegration' )
method is used in server logic.enable_feature( 'ga4AdSenseIntegration' )
method is used in PHP test files.ga4AdSenseIntegration
feature flag. However, it is better to double-check this.ga4AdSenseIntegration
feature is activated. Here, it is necessary to remove this particular parameter.Test Coverage
ga4AdSenseIntegration
feature flag.QA Brief
ga4AdSenseIntegration
feature flag should not appear in the list of feature flags when using the tester plugin.Essentially: test that GA4 + AdSense features appear without the
ga4AdSenseIntegration
being enabled.Changelog entry