Closed tofumatt closed 8 months ago
IB + CR ✅
For the QAB, this may be problematic if we can't consistently trigger the refocus callback as we saw re: #8297.
@tofumatt , In the QAB, this point states, "ensure your AdSense account status is set and not set to 'Ready'." However, it's not clear which AdSense account status should be set. Could you please clarify and update this point?
Ah, really any status other than the default, but these are the settings I used during testing:
Verified:
Bug Description
The
clearError()
call here was not updated in #5858: https://github.com/google/site-kit-wp/blob/a84602fd1db5a2e89fe24943aae01ba29db6caf3/assets/js/modules/adsense/components/setup/SetupMain.js#L230. This means if an error was encountered during AdSense setup, and the user retries, the error will not be cleared and they'll need to do a full-page refresh.Because of this, it isn't a show-stopping bug, though if it's straightforward would be great to get out in this release.
Steps to reproduce
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
baseName is required
) when it resets the error after the refocus code is triggered when the user navigates away from and back to the tab with AdSense setup open.Implementation Brief
clearError()
call fromSetupMain
in AdSense: https://github.com/google/site-kit-wp/blob/a84602fd1db5a2e89fe24943aae01ba29db6caf3/assets/js/modules/adsense/components/setup/SetupMain.js#L230Test Coverage
QA Brief
Changelog entry