google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.25k stars 291 forks source link

`clearError()` call is missing `baseName` in AdSense setup component #8294

Closed tofumatt closed 8 months ago

tofumatt commented 8 months ago

Bug Description

The clearError() call here was not updated in #5858: https://github.com/google/site-kit-wp/blob/a84602fd1db5a2e89fe24943aae01ba29db6caf3/assets/js/modules/adsense/components/setup/SetupMain.js#L230. This means if an error was encountered during AdSense setup, and the user retries, the error will not be cleared and they'll need to do a full-page refresh.

Because of this, it isn't a show-stopping bug, though if it's straightforward would be great to get out in this release.

Steps to reproduce

  1. Set up Site Kit
  2. Using the tester plugin, ensure your AdSense account status is set and not set to "Ready"
  3. Go to the AdSense setup page
  4. Wait for the content to load
  5. Go to another tab in Chrome and wait 30+ seconds.
  6. Return to the AdSense setup tab and see an error

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

aaemnnosttv commented 8 months ago

IB + CR ✅

For the QAB, this may be problematic if we can't consistently trigger the refocus callback as we saw re: #8297.

mohitwp commented 8 months ago

@tofumatt , In the QAB, this point states, "ensure your AdSense account status is set and not set to 'Ready'." However, it's not clear which AdSense account status should be set. Could you please clarify and update this point?

tofumatt commented 8 months ago

Ah, really any status other than the default, but these are the settings I used during testing:

Screenshot 2024-02-22 at 18 24 53

wpdarren commented 8 months ago

QA Update: ✅

Verified:

Screenshots ![image](https://github.com/google/site-kit-wp/assets/73545194/8bf9e51a-e872-4c7d-a173-c4a4e6d8c56b) ![image](https://github.com/google/site-kit-wp/assets/73545194/b984a2b0-b235-415f-9e24-2e25227192b0)