search

google / site-kit-wp

Site Kit is a one-stop solution for WordPress users to use everything Google has to offer to make them successful on the web.
https://sitekit.withgoogle.com
Apache License 2.0
1.22k stars 278 forks source link

Link to Dashboard in PSI settings no longer works #8373

Open wpdarren opened 6 months ago

wpdarren commented 6 months ago

Bug Description

Within Page Speed Insights settings, a link takes the user back to the dashboard to view the insights widget. When you click on it you are redirected to the dashboard but no longer to the PSI widget area. The URL is /wp-admin/admin.php?page=googlesitekit-dashboard#speed, which is correct.

It only seems to be an issue when all of AdSense, Analytics, Search Console, and PageSpeed modules are connected.

https://github.com/google/site-kit-wp/assets/73545194/f52a5448-d518-4d2b-8582-a7ef09d7fffc

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

tofumatt commented 3 months ago

I can't reproduce the issue. Here's a screen recording with all four modules connected:

https://github.com/google/site-kit-wp/assets/90871/cabf6f0d-35c8-4be7-8e24-f7768856d652

@wpdarren: Can you check to see if you can still reproduce this? If not we can close it. 👍🏻

wpdarren commented 3 months ago

@tofumatt that's weird because I am able to recreate it. I am using the latest version of Chrome on MacOS. I do have the key metrics widget set up, so not sure if that's the difference.

https://github.com/google/site-kit-wp/assets/73545194/92bfba0b-c8fd-4d82-b075-10a10df2d08e

tofumatt commented 1 month ago

I activated the Key Metrics widget and could not reproduce the issue 🤔

https://github.com/user-attachments/assets/6f1b1167-4b88-4173-8177-6aaff2e67dc9

@wpdarren Can you try it with a Chrome window that has no browser add-ons installed? I'm seeing a lot of extension icons in that Chrome window and I'm wondering if they're causing issues 😅

wpdarren commented 1 month ago

@tofumatt this is an interesting bug! So, I got my investigator hat on and think I have discovered the issue...

I ran through a series of tests with some or all modules connected, both in incognito with my browser extensions enabled and disabled, and I could recreate the issue every time.

I then reset my site, and did the same but this time I did not set up key metrics and the bug was no longer appearing.

After a bit of time I realised that this issue only exists when you change the key metric tiles. When you complete the survey, and the default tiles appear the issue does not exist. If I then go ahead and change one or more of the metrics, the behaviour reported in this ticket continuously appears. Could you see if you can recreate?

https://github.com/user-attachments/assets/d047e51b-88b5-4569-a192-b760ca2ffef1